Changeset 3111859

Timestamp:

07/03/2024 04:11:39 PM (5 weeks ago)

Author:

whiteshadow

Message:

Fix duplicate "WooCommerce -> Subscriptions" menu items.

Reported by a user, but wasn't tested because WooCommerce Subscriptions is a paid extension. Implementation based on URLs reported by the user.

File:

• admin-menu-editor/trunk/includes/menu-editor-core.php (modified) (1 diff)

admin-menu-editor/trunk/includes/menu-editor-core.php

@@ -4394 +4394 @@
          * is active because it happens in the admin_init hook.
          *
-         * Let's check if there are two "Orders" items and remove the one that uses custom post types.
+         * According to user reports, when the WooCommerce Subscriptions extension is active, the same
+         * problem happens with the "WooCommerce -> Subscriptions" item.
+         *
+         * Let's check if there are duplicate items and remove the ones that use custom post types.
          */
-        $goodOrdersItemIndex = null;
-        $redundantOrdersItemIndex = null;
-        foreach($this->default_wp_submenu['woocommerce'] as $index => $menu) {
-            //Skip menu items without a slug/URL in case someone adds a custom separator or something.
-            if ( !isset($menu[2]) ) {
-                continue;
-            }
-            if ( $menu[2] === 'edit.php?post_type=shop_order' ) {
-                $redundantOrdersItemIndex = $index;
-            } elseif ( $menu[2] === 'wc-orders' ) {
-                $goodOrdersItemIndex = $index;
-            }
-        }
-
-        if ( ($goodOrdersItemIndex !== null) && ($redundantOrdersItemIndex !== null) ) {
-            unset($this->default_wp_submenu['woocommerce'][$redundantOrdersItemIndex]);
+        $potentialDuplicateItems = [
+            'edit.php?post_type=shop_order'        => 'wc-orders',
+            'edit.php?post_type=shop_subscription' => 'wc-orders--shop_subscription',
+        ];
+        foreach ($potentialDuplicateItems as $redundantSlug => $goodSlug) {
+            $redundantItemIndex = null;
+            $goodItemIndex = null;
+            foreach ($this->default_wp_submenu['woocommerce'] as $index => $menu) {
+                //Skip menu items without a slug/URL in case someone adds a custom separator or something.
+                if ( !isset($menu[2]) ) {
+                    continue;
+                }
+                if ( $menu[2] === $redundantSlug ) {
+                    $redundantItemIndex = $index;
+                } elseif ( $menu[2] === $goodSlug ) {
+                    $goodItemIndex = $index;
+                }
+            }
+            if ( ($goodItemIndex !== null) && ($redundantItemIndex !== null) ) {
+                unset($this->default_wp_submenu['woocommerce'][$redundantItemIndex]);
+            }
         }
     }