Changeset 3108797

Timestamp:

06/27/2024 02:45:01 PM (6 weeks ago)

Author:

whiteshadow

Message:

Fix WooCommerce conflict where two "Orders" menu items would appear when AME was active.

In certain configurations, WooCommerce creates two "WooCommerce -> Orders" menu items. This may be related to whether the "High-performance order storage" setting is enabled in WooCommerce. One "Orders" menu item is for the "Orders" CPT, while the other is a custom (more recent?) "wc-orders" item. WooCommerce removes the CPT item in "admin_init", which doesn't work with AME because AME processes the menu before that, in "admin_menu".

The current workaround is to check if both items exist and to remove one. Unfortunately, there doesn't seem to be a better way to do this since remove_submenu_page() is not hookable and moving menu processing to "admin_init" would interfere with some AME features, like custom menu permissions.

File:

• admin-menu-editor/trunk/includes/menu-editor-core.php (modified) (3 diffs)

admin-menu-editor/trunk/includes/menu-editor-core.php

@@ -4355 +4355 @@
 
     /**
-     * Compatibility fix for WooCommerce 2.2.1+.
-     * Summary: When AME is active, an unusable WooCommerce -> WooCommerce menu item shows up. Here we remove it.
-     *
-     * WooCommerce creates a top level "WooCommerce" menu with no callback. By default, WordPress automatically adds
-     * a submenu item with the same name. However, since the item doesn't have a callback, it is unusable and clicking
-     * it just triggers a "Cannot load woocommerce" error. So WooCommerce removes this item in an admin_head hook to
-     * hide it. With AME active, the item shows up anyway, and users get confused by the error.
-     *
-     * Fix it by removing the problematic menu item.
-     *
-     * Caution: If the user hides all WooCommerce submenus but not the top level menu, the WooCommerce menu will still
-     * show up but be inaccessible. This may be slightly counter-intuitive, but seems reasonable.
+     * Compatibility fixes for WooCommerce.
      */
     private function apply_woocommerce_compat_fix() {
@@ -4373 +4362 @@
         }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         $badSubmenuExists = isset($this->default_wp_submenu['woocommerce'][0][2])
             && ($this->default_wp_submenu['woocommerce'][0][2] === 'woocommerce');
@@ -4380 +4385 @@
             $this->default_wp_submenu['woocommerce'][0] = $this->default_wp_submenu['woocommerce'][1];
             unset($this->default_wp_submenu['woocommerce'][1]);
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         }
     }