Changeset 2948258

Timestamp:

08/06/2023 11:06:07 PM (12 months ago)

Author:

celloexpressions

Message:

Sheet Music Library: Improve conditional logic for sheet music piece date modified determination.

File:

• sheet-music-library/trunk/template/template-parts.php (modified) (3 diffs)

sheet-music-library/trunk/template/template-parts.php

@@ -59 +59 @@
 
 // Returns markup for last updated text for sheet music PDFs. Displays the newer date of the score and parts attachment files.
+
 function sml_sheet_music_last_updated_text( $score_url = false, $parts_url = false ) {
     if ( ! $score_url ) {
@@ -65 +66 @@
         $score_attachment_id = absint( attachment_url_to_postid( $score_url ) );
     }
-    $score_date = get_the_modified_date( 'U', $score_attachment_id );
+    // Handle empty attachment.
+    if ( $score_attachment_id ) {
+        $score_date = get_the_modified_date( 'U', $score_attachment_id );
+    } else {
+        $score_date = 0;
+    }
 
     if ( ! $parts_url ) {
@@ -72 +78 @@
         $parts_attachment_id = absint( attachment_url_to_postid( $parts_url ) );
     }
-    $parts_date = get_the_modified_date( 'U', $parts_attachment_id );
+    // Handle empty attachment.
+    if ( $parts_attachment_id ) {
+        $parts_date = get_the_modified_date( 'U', $parts_attachment_id );   
+    } else {
+        $parts_date = 0;
+    }
+
+    // Ensure that the modified date is not before the piece publish date.
+    $post_publish = absint( get_the_date( 'U', get_the_ID() ) );
 
     // Report the more recent attachment modified date. Note this is not necessarily the file-modified date, but any other attachment modify triggers are unlikely.
-    if ( $score_date > $parts_date ) {
+    // Falls back to the post published date if both attachments are missing.
+    if ( $post_publish > $score_date && $post_publish > $parts_date ) {
+        $date = get_the_date( 'F j, Y', get_the_id() );
+    } elseif ( $score_date > $parts_date ) {
         $date = get_the_modified_date( 'F j, Y', $score_attachment_id );
     } else {