Changeset 13871

Timestamp:

07/03/2024 03:58:32 AM (5 weeks ago)

Author:

dd32

Message:

Plugin Directory: Allow reviewers to remove themselves from a plugin, even if it leaves no committers. Likewise, allow them to remove committers from closed plugins.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/list-table/class-committers.php (modified) (1 diff)
• admin/metabox/class-committers.php (modified) (1 diff)
• api/routes/class-plugin-committers.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-committers.php

@@ -162 +162 @@
         // Check if the committer for this row is removable.
         $post_id = get_post()->ID;
-        if ( current_user_can( 'plugin_remove_committer', $post_id ) && $user_object->ID != get_current_user_id() ) {
+        if ( current_user_can( 'plugin_remove_committer', $post_id ) ) {
             $actions['delete'] = "<a class='submitremove' data-wp-lists='delete:the-committer-list:committer-{$user_object->ID}:faafaa:post_id={$post_id}' href='" . wp_nonce_url( 'users.php?action=remove&amp;committer=' . $user_object->ID, "remove-committer-{$user_object->ID}" ) . "'>" . __( 'Remove', 'wporg-plugins' ) . '</a>';
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-committers.php

@@ -99 +99 @@
         check_ajax_referer( "remove-committer-$id" );
 
-        if ( ! current_user_can( 'plugin_remove_committer', $post_id ) || 'publish' !== get_post_status( $post_id ) ) {
+        if ( ! current_user_can( 'plugin_remove_committer', $post_id ) ) {
             wp_die( -1 );
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-committers.php

@@ -142 +142 @@
 
         // Prevent a committer removing themselves, if they're the only committer.
-        if ( $user->user_login == wp_get_current_user()->user_login ) {
+        if ( $user->user_login == wp_get_current_user()->user_login ) {
             $committers = Tools::get_plugin_committers( $plugin_slug );
             if ( count( $committers ) == 1 && in_array( $user->user_login, $committers ) ) {