Changeset 13088

Timestamp:

01/02/2024 02:44:07 AM (7 months ago)

Author:

tellyworth

Message:

Plugin Directory: Improved preview links for plugin mods

This adds separate "preview" and "pcp" links.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/list-table/class-plugin-posts.php (modified) (1 diff)
• admin/metabox/class-review-tools.php (modified) (1 diff)
• api/routes/class-plugin-blueprint.php (modified) (2 diffs)
• class-template.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -712 +712 @@
 
             printf(
-                '<a href="%1$s">%2$s</a><br>%3$s<br>(<a href="%4$s" target="_blank">preview</a>)</li>',
+                '<a href="%1$s">%2$s</a><br>%3$s<br>(<a href="%4$s" target="_blank">preview</a>)</li>',
                 esc_url( $url ),
                 esc_html( $name ),
                 esc_html( $zip_size ),
-                esc_url( Template::preview_link_zip( $post->post_name, $zip_file->ID ) )
+                esc_url( Template::preview_link_zip( $post->post_name, $zip_file->ID ) ),
+                esc_url( Template::preview_link_zip( $post->post_name, $zip_file->ID, 'pcp' ) )
             );
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -129 +129 @@
                 $zip_size                   = size_format( filesize( get_attached_file( $zip_file->ID ) ), 1 );
                 $zip_preview                = Template::preview_link_zip( $slug, $zip_file->ID );
+
 
                 printf(
-                    '<li>%1$s <a href="%2$s">%3$s</a> (%4$s) (<a href="%5$s" target="_blank">preview</a>)</li>',
+                    '<li>%1$s <a href="%2$s">%3$s</a> (%4$s) (<a href="%5$s" target="_blank">preview</a>)</li>',
                     esc_html( $zip_date ),
                     esc_url( $zip_url ),
                     esc_html( basename( $zip_url ) ),
                     esc_html( $zip_size ),
-                    esc_url( $zip_preview )
+                    esc_url( $zip_preview ),
+                    esc_url( $zip_pcp )
                 );
             }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-blueprint.php

@@ -37 +37 @@
         $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
 
-        // Direct zip preview for plugin reviewers
         if ( $request->get_param('zip_hash') ) {
-            foreach ( get_attached_media( 'application/zip', $plugin ) as $zip_file ) {
-                if ( hash_equals( Template::preview_link_hash( $zip_file->ID, 0 ), $request->get_param('zip_hash') ) ||
-                     hash_equals( Template::preview_link_hash( $zip_file->ID, -1 ), $request->get_param('zip_hash') ) ) {
-                    $zip_url = wp_get_attachment_url( $zip_file->ID );
-                    $zip_blueprint =<<<EOF
-{
-    "landingPage": "/wp-admin/plugins.php",
-    "preferredVersions": {
-        "php": "8.0",
-        "wp": "latest"
-    },
-    "phpExtensionBundles": [
-        "kitchen-sink"
-    ],
-    "features": {
-        "networking": true
-    },
-    "steps": [
-        {
-            "step": "installPlugin",
-            "pluginZipFile": {
-                "resource": "wordpress.org/plugins",
-                "slug": "plugin-check"
-            }
-        },
-        {
-            "step": "installPlugin",
-            "pluginZipFile": {
-                "resource": "url",
-                "url": "$zip_url"
-            }
-        },
-        {
-            "step": "login",
-            "username": "admin",
-            "password": "password"
-        }
-    ]
-}
-EOF;
-                    header( 'Access-Control-Allow-Origin: https://playground.wordpress.net' );
-                    die( $zip_blueprint );
-                }
-            }
+            $this->reviewer_blueprint( $request, $plugin );
         }
 
@@ -102 +58 @@
     }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -772 +772 @@
      * @return false|string           The preview URL.
      */
-    public static function preview_link_zip( $slug, $attachment_id ) {
+    public static function preview_link_zip( $slug, $attachment_id ) {
 
         $zip_hash = self::preview_link_hash( $attachment_id );
@@ -779 +779 @@
         }
         $zip_blueprint = sprintf( 'https://wordpress.org/plugins/wp-json/plugins/v1/plugin/%s/blueprint.json?zip_hash=%s', esc_attr( $slug ), esc_attr( $zip_hash ) );
+
+
+
         $zip_preview = add_query_arg( 'blueprint-url', urlencode($zip_blueprint), 'https://playground.wordpress.net/' );