Changeset 12999

Timestamp:

12/04/2023 04:42:52 AM (8 months ago)

Author:

tellyworth

Message:

Plugins: improved Test Preview button

This uses the new Playground blueprint-url param to pass the blueprint rather than a URL fragment.

Also, opens the preview in a new tab, as per suggestions.

See #7251.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/api/class-base.php (modified) (1 diff)
• plugins/plugin-directory/api/routes/class-plugin-blueprint.php (modified) (1 diff)
• plugins/plugin-directory/class-plugin-directory.php (modified) (3 diffs)
• plugins/plugin-directory/class-template.php (modified) (1 diff)
• themes/pub/wporg-plugins/template-parts/plugin-single.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/class-base.php

@@ -39 +39 @@
         new Routes\Plugin_Categorization();
         new Routes\Plugin_Upload();
+
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-blueprint.php

@@ -37 +37 @@
         $blueprints = get_post_meta( $plugin->ID, 'assets_blueprints', true );
         // Note: for now, only use a file called `blueprint.json`.
-        if ( !isset( $blueprints['blueprint.json'] ) ) {
-            return false;
+if ( !isset( $blueprints['blueprint.json'] ) ) {
+;
         }
         $blueprint = $blueprints['blueprint.json'];
         if ( !$blueprint || !isset( $blueprint['contents'] ) || !is_string( $blueprint['contents'] ) ) {
-            return false;
+;
         }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -50 +50 @@
         add_action( 'wp_head', array( Template::class, 'json_ld_schema' ), 1 );
         add_action( 'wp_head', array( Template::class, 'hreflang_link_attributes' ), 2 );
+
 
         // Add no-index headers where appropriate.
@@ -1392 +1393 @@
         }
 
+
+
+
+
+
+
+
         if ( is_comment_feed() ) {
             wp_redirect( 'https://wordpress.org/plugins/', 301 );
@@ -1397 +1405 @@
         }
 
+
+
+
+
+
+
+
+
+
+
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -758 +758 @@
         }
 
-        $blueprint_encoded = esc_html( str_replace( '%', '%25', $blueprint['contents'] ) );
-
-        return sprintf( 'https://playground.wordpress.net/?plugin=%s#%s', $post->post_name, $blueprint_encoded );
+        $blueprint_ );
+
+        return sprintf( 'https://playground.wordpress.net/?plugin=%s );
     }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -43 +43 @@
             <?php endif; ?>
             <?php if ( current_user_can( 'plugin_admin_edit', $post ) && Template::is_preview_available() ) : ?>
-                <a class="plugin-preview button download-button button-large" href="<?php echo esc_html( Template::preview_link() ); ?>"><?php esc_html_e( 'Test Preview', 'wporg-plugins' ); ?></a>
+                <a class="plugin-preview button download-button button-large" ) ); ?>"><?php esc_html_e( 'Test Preview', 'wporg-plugins' ); ?></a>
             <?php endif; ?>
         </div>