Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://cp-algorithms.com/ - Lots of blank space after footer of page #47748

Closed
1 task done
etanot opened this issue Jan 19, 2020 · 5 comments
Closed
1 task done

https://cp-algorithms.com/ - Lots of blank space after footer of page #47748

etanot opened this issue Jan 19, 2020 · 5 comments

Comments

@etanot
Copy link

etanot commented Jan 19, 2020

URL: https://cp-algorithms.com/

Browser/Version: Firefox 71

Operating System: Android

What seems to be the trouble?(Required)

  • Design is broken

Steps to Reproduce

  1. Navigate to: https://cp-algorithms.com/.
  2. Scroll down to the footer of page.

Expected Behavior:
No blank spaces after footer.

Actual Behavior:
Lots of blank space after footer of page.

Additional

On Fenix, design of https://cp-algorithms.com is broken. There is lots of blank space, after footer of the website; I tried to reproduce this behavior on Chromium based browser and Firefox Android, but couldn't reproduce it. Seems like issue is with CSS rule.

Screenshots

Screenshot

@anonymousbot anonymousbot added this to the needstriage milestone Jan 19, 2020
@anonymousbot anonymousbot added browser-fixme This requires manual assignment for the browser name and removed status-needsinfo-cipriansv status-needsinfo-oana ping @softvision-oana-arbuzov labels Jan 19, 2020
@cipriansv cipriansv added browser-fenix and removed browser-fixme This requires manual assignment for the browser name labels Jan 20, 2020
@softvision-oana-arbuzov
Copy link
Member

Thanks for the report, I was able to reproduce the issue.
image

Note: The issue is also reproducible on Firefox Nightly.

Tested with:
Browser / Version: Firefox Preview Nightly 200117 (🦎: 74.0a1-20200115093807)
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

Moving to Needsdiagnosis for further investigation.

@denschub
Copy link
Member

denschub commented Apr 9, 2020

So, this site has a very interesting way to ensure the content is never "too wide" for the device, without adding line breaks or anything:

window.onresize = function(){
  var w0 = 980;
  var w1 = $(window).width();
  if (w1 < w0) {
    var zoom = Math.floor(w1 * 100 / w0);
    document.body.style.zoom = "" + zoom + "%";
    document.body.style.MozTransform = 'scale(0.' + zoom + ')';
    document.body.style.MozTransformOrigin = '0 0';
  } else {
    document.body.style.zoom = "";
    document.body.style.MozTransform = '';
  }
};

So, whenever the display is narrower than it should be, they just... scale everything down. For that, they do set both zoom, as well as a -moz-transform: scale(). zoom is not supported in Firefox, so it has no effect. And the scale has the effect of making the contents smaller, but not actually making the elements bounding box smaller, so if you set scale(0.5), you'll have exactly 50% whitespace in the bottom of the site.

Without supporting zoom, the only other solution would be to kindly suggest them to reengineer the whole site, which I think isn't going to happen. I'll therefore close this bug as a duplicate of the Mozilla zoom bug.

@lock
Copy link

lock bot commented Apr 18, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue at https://webcompat.com/issues/new if you are experiencing a similar problem.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
@ksy36 ksy36 modified the milestones: duplicate, worksforme Jul 21, 2022
@ksy36
Copy link
Contributor

ksy36 commented Jul 21, 2022

Looks like the design has changed, the issue no longer reproduces

@softvision-oana-arbuzov
Copy link
Member

I can confirm it no longer reproduces, there is no empty space after the page footer.
image

Tested with:
Browser / Version: Firefox Nightly 105.0a1 (🦎 105.0a1-20220726094428)
Operating System: Google Pixel 5 (Android 12) - 1080 x 2340 pixels, 19.5:9 ratio (~432 ppi density), Samsung Galaxy S8 (Android 9) - 1440 x 2960 pixels, 18.5:9 ratio (~570 ppi density)

[inv_30/2022]

@softvision-oana-arbuzov softvision-oana-arbuzov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.