Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dropzone tests #5053

Open
pwnall opened this issue Mar 6, 2017 · 0 comments
Open

Remove dropzone tests #5053

pwnall opened this issue Mar 6, 2017 · 0 comments
Labels
html

Comments

@pwnall
Copy link
Contributor

pwnall commented Mar 6, 2017

The dropzone attribute is being removed from the HTML specification in whatwg/html#2402 and should be removed from WPT. This is not a trivial find-and-remove because we need to make sure that the tests we remove aren't intended to cover other functionality.

For example, Blink had tests that used dropzone and also covered the interaction between DataTransfer.effectAllowed and DataTransfer.dropEffect, which had to be rewritten in https://codereview.chromium.org/2729353002/

This issue will track my efforts to sift through all tests that contain dropzone and update or remove them.
@pwnall pwnall mentioned this issue Mar 6, 2017
Merged
domenic pushed a commit to whatwg/html that referenced this issue Mar 6, 2017
@pwnall @domenic
Remove the dropzone global attribute
3044a7e 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

WebKit and Blink implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Blink [1]. WebKit has no objections
to the attribute getting removed from the spec [2].

Fixes #2331. Tests:

* web-platform-tests/wpt#5052
* web-platform-tests/wpt#5053

[1]: https://www.chromestatus.com/feature/5718005866561536
[2]: #2331 (comment)
@gsnedders gsnedders added the html label Apr 5, 2017
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@pwnall
Remove the dropzone global attribute
4a85dca 
dropzone failed to get traction among browser implementers. Having it in
the specification is confusing to Web developers who may attempt to use
it, only to discover that it is not supported.

WebKit and Blink implemented a prefixed version, webkitdropzone. The
prefixed version is going away from Blink [1]. WebKit has no objections
to the attribute getting removed from the spec [2].

Fixes whatwg#2331. Tests:

* web-platform-tests/wpt#5052
* web-platform-tests/wpt#5053

[1]: https://www.chromestatus.com/feature/5718005866561536
[2]: whatwg#2331 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
html
2 participants
@pwnall @gsnedders