Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo account deletion (blocked on Bluesky) #1130

Open
snarfed opened this issue Jun 13, 2024 · 12 comments
Open

Undo account deletion (blocked on Bluesky) #1130

snarfed opened this issue Jun 13, 2024 · 12 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jun 13, 2024

Right now, blocking the bridge bot account disables the bridge for you and deletes your bridged account. That's almost too easy, and right now it can't be undone, which is unfortunate. We should allow undeleting! Background in #783

@lupomancer
Copy link

lupomancer commented Jun 13, 2024

In an ideal world where this is solved, would this allow for blocking and unblocking from both Mastodon and Bluesky?

If, say, I want to delete my bridged mastodon -> BSKY account for the time being to avoid confusion, would I later be able to follow the bridger and recreate it?

Additionally, were I to delete my bridged BSKY -> Mastodon account, changed my BSKY handle, and then refollowed, would it create an account with the new BSKY handle? I know this may be blocked by that annoying AP username issue outlined in #1074

@snarfed
Copy link
Owner Author

snarfed commented Jun 13, 2024

Blocking and unblocking to recreate the bridged account is definitely the goal!

Handle changes are a separate question, you're right, #1074 tracks that.

@qazmlp
Copy link

qazmlp commented Jun 13, 2024

For what it's worth, once this here is implemented, then the handle change should be reflected in Mastodon this way, at least if you wait a few hours between actions.

You'd still lose all your fediverse connections, but your follows could in theory be re-synchronised. (#1102)
Not your followers though, they'd be lost permanently when doing this.

@snarfed
Copy link
Owner Author

snarfed commented Jun 13, 2024

Not sure I follow, but if you mean that deleting and recreating bridged accounts like this this should give us Bluesky => fediverse handle changes for free, I don't think so. Background in #1074 (comment) .

TLDR is that the actor id itself wouldn't change, and right now it's unclear how broadly the fediverse currently supports either 1) changing an actor's username while keeping its id the same or 2) deleting and recreating an actor with the same id. Both probably need some testing in the wild.

@qazmlp
Copy link

qazmlp commented Jun 13, 2024

For Mastodon specifically, I think it uses WebFinger existence to check whether to keep an account alive regarding a cleanup job.

But you're right, while I don't see a uniqueness constraint on the actor id, it's definitely possible that some part of it would glitch out.

@snarfed
Copy link
Owner Author

snarfed commented Jun 29, 2024

Looks like this is already working for Bluesky => fediverse! jglypt on Bluesky blocked @ap.brid.gy at 2024-06-21T22:47:15.283184Z, and we disabled his account and sent out Deletes for his AP actor (see below). He then unblocked and re-followed it at 2024-06-22T13:14:02Z, and fediverse instances were able to see his actor again. Posts before the block aren't visible, but posts after it are.

{
  "id": "https://bsky.brid.gy/convert/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v#delete-copy-activitypub-2024-06-21T22:47:15.283184+00:00",
  "actor": "https://bsky.brid.gy/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v",
  "@context": "https://www.w3.org/ns/activitystreams",
  "type": "Delete",
  "object": "https://bsky.brid.gy/ap/did:plc:4hawmtgzjx3vclfyphbhfn7v",
  "to": ["https://www.w3.org/ns/activitystreams#Public"]
}

We weren't sure, if we Deleted an actor in AP with a given id, whether we could later recreate that actor with the same id. Our next step was to test it (#783 (comment)). Thanks Jack for doing that test for us!

@snarfed
Copy link
Owner Author

snarfed commented Jun 29, 2024

So, fediverse => Bluesky is the remaining one here.

@snarfed
Copy link
Owner Author

snarfed commented Jul 16, 2024

...specifically, the remaining work for fediverse => Bluesky here is to figure out how to reactivate an ATProto repo that has been tombstoned: bluesky-social/atproto#2503 (reply in thread) . Related: #1119, bluesky-social/atproto#2592 . cc @lupomancer

@snarfed snarfed added the now label Jul 16, 2024
@snarfed
Copy link
Owner Author

snarfed commented Jul 16, 2024

Hmm. I tried undelete a tombstoned repo (snarfed.org.web.brid.gy / did:plc:vzxheqfwpbi3lxbgdh22js66) by emitting an #account event with "active": True, but no luck. https://bsky.app/profile/snarfed.org.web.brid.gy still says Profile not found.

{
  "op": 1,
  "t": "#account"
}
{
  "did": "did:plc:vzxheqfwpbi3lxbgdh22js66",
  "seq": 1131666,
  "time": "2024-07-16T20:26:56.540365+00:00",
  "active": true
}
@snarfed
Copy link
Owner Author

snarfed commented Jul 23, 2024

Asked @bnewbold about this ^ in https://bsky.app/profile/snarfed.org/post/3kxgh6bl6lu2j , haven't heard back yet.

@snarfed snarfed added now and removed now labels Jul 23, 2024
@snarfed
Copy link
Owner Author

snarfed commented Jul 24, 2024

Heard back that #identity + #account should do the trick!

...except that doesn't seem to work yet. I emitted the two events below over BF's firehose just now, and got them back from the relay's firehose intact, but https://bsky.app/profile/snarfed.org.web.brid.gy still says Profile not found. https://enoki.us-east.host.bsky.network/xrpc/app.bsky.actor.getProfile?actor=did:plc:vzxheqfwpbi3lxbgdh22js66 returns 400 with the same error, as does the same call on api.bsky.app. BF hasn't received any getRepo calls for this DID recently.

@bnewbold any thoughts? could this be a bug in the Bluesky relay or appview or nearby?

{"op": 1, "t": "#identity"}
{
  "did": "did:plc:vzxheqfwpbi3lxbgdh22js66",
  "seq": 1221600,
  "time": "2024-07-24T17:02:27.223965+00:00",
  "handle": "snarfed.org.web.brid.gy"
}

{"op": 1, "t": "#account"}
{
  "did": "did:plc:vzxheqfwpbi3lxbgdh22js66",
  "seq": 1221601,
  "time": "2024-07-24T17:02:28.151528+00:00",
  "active": true
}
@snarfed
Copy link
Owner Author

snarfed commented Jul 24, 2024

@snarfed snarfed changed the title Undo account deletion Jul 25, 2024
@snarfed snarfed removed the now label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants