Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package authentication documentation has confusing PAT wording #33926

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Package authentication documentation has confusing PAT wording #33926

wants to merge 3 commits into from

Conversation

syntastical
Copy link

@syntastical syntastical commented Jul 10, 2024 •
edited
Loading

Why:

Closes: #33925

What's being changed (if available, include any code snippets, screenshots, or gifs):

Both of the following links make reference to only being able to authenticate to GitHub packages using a PAT but that's misleading, and even contradicted on the same page by references to using GITHUB_SECRET in GitHub actions.
https://docs.github.com/en/packages/learn-github-packages/publishing-a-package
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.
@welcome Welcome
Copy link

welcome bot commented Jul 10, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
packages/learn-github-packages/publishing-a-package.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
packages/learn-github-packages/introduction-to-github-packages.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-apache-maven-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-container-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-docker-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-gradle-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-npm-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-nuget-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable
packages/working-with-a-github-packages-registry/working-with-the-rubygems-registry.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 10, 2024
@nguyenalex836
Copy link
Contributor

@syntastical Thanks so much for opening a PR! I'll get this triaged for review ✨
@felicitymay
Copy link
Contributor

Thanks for raising this PR. I agree that the text of the note is misleading and have proposed an alternative solution. See:

While we discuss the best solution to the problem you identified, I'm going to label this PR as on hold.
@felicitymay felicitymay added Review on hold Discussions on the best resolution are in progress, do not merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jul 19, 2024
@github-actions github-actions bot closed this Jul 19, 2024
@nguyenalex836
Copy link
Contributor

Reopening per comment here!
@nguyenalex836 nguyenalex836 reopened this Jul 19, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Jul 19, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 19, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team Review on hold Discussions on the best resolution are in progress, do not merge
3 participants
@syntastical @nguyenalex836 @felicitymay