Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #33907 #33914

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix: #33907 #33914

merged 3 commits into from
Jul 11, 2024

Conversation

Venki1402
Copy link
Contributor

Why:

Closes: #33907

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.
@welcome Welcome
Copy link

welcome bot commented Jul 10, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 10, 2024
@Venki1402 Venki1402 mentioned this pull request Jul 10, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/managing-subscriptions-and-notifications-on-github/managing-subscriptions-for-activity-on-github/managing-your-subscriptions.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team account-and-profile Content relating to account and profile and removed triage Do not begin working on this issue until triaged by the team labels Jul 10, 2024
@nguyenalex836
Copy link
Contributor

@Venki1402 Thanks so much for opening a PR! ✨ It looks like a new file, gitpod.yml, is being introduced alongside the fixes. Would you be able to remove that file from your PR? We can get this PR merged right after 💛
@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Jul 10, 2024
@Venki1402
Copy link
Contributor Author

Venki1402 commented Jul 11, 2024 •
edited
Loading

@nguyenalex836 I've removed it. Is it fine now?
@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label Jul 11, 2024
@nguyenalex836
Copy link
Contributor

@Venki1402 Thank you for that update! I'll update the branch and get this merged once tests are passing 🍏
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into github:main with commit e375d03 Jul 11, 2024
44 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team
2 participants
@Venki1402 @nguyenalex836