Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari can’t install this extension #86

Closed
david-macrae opened this issue Jan 19, 2018 · 59 comments
Closed

Safari can’t install this extension #86

david-macrae opened this issue Jan 19, 2018 · 59 comments

Comments

@david-macrae
Copy link

Filter issues MUST NOT be reported here. Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

the latest build 1.14.24 that was just uploaded will not install.

safari just pops up with a warning: Safari can’t install this extension

One or more specific URLs where the issue occurs

[URL(s) for issue on a specific site are mandatory]

Screenshot in which the issue can be seen

[Screenshot(s) for visual issues are mandatory]

Steps for anyone to reproduce the issue

  1. Be as detailed as possible:
  2. Because we are not looking over your shoulder and
  3. Keep in mind: Nobody can read your mind.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

  • MacOS version:
  • Safari version:
  • uBlock Origin version:
Your filter lists

[Example: "Default filter lists + FRA", or "Default filter lists minus uBlock -- Badware risks"]

Your custom filters (if any)
@ghost
Copy link

ghost commented Jan 19, 2018

Yeah same here, and the update button in Safari Extension Updates does nothing.

@Baccount
Copy link

Im also effected running macOS 10.13.2 (17C205) Safari 11.0.2

@danmcquade
Copy link

Same issue here. Tried on two different Macs, both running 10.13.2 (17C205) with Safari 11.0.2.

screen shot 2018-01-18 at 7 20 01 pm

@mustii82
Copy link

same problem :/

@ruchernchong
Copy link

ruchernchong commented Jan 19, 2018

macOS Version: macOS 10.13.3 Beta 4 (17D39a)
Safari Version: Version 11.0.3 (13604.5.6)

Description:

Unable to install the extension for 1.14.24

@sheelgautam
Copy link

macOS Version 10.13.2 (17C205)
Safari Version 11.0.2 (13604.4.7.1.6)

Can install Ub0 1.14.14 but cannot install 1.14.24.
Error : Safari can't install this extension.
Can install other extensions in addition to extensions from Safari Extension Gallery.

@MysticalOS
Copy link

Won't install or upgrade from gallery in safari or tech preview. it just rejects .24 version

@maciboy
Copy link

maciboy commented Jan 19, 2018

Same :/

@volcbs
Copy link

volcbs commented Jan 19, 2018

Wow, I thought I was the only one. Got the same problem here.
MacOS 10.12.6
Safari 11.0.2

@gorhill
Copy link

gorhill commented Jan 19, 2018

Did any of you try what was suggested in #85 (comment)?

Run sudo softwareupdate -i -a in terminal and it should install any updates.

@danmcquade
Copy link

Did any of you try what was suggested in #85 (comment)?

Tried this on both of my machines. Both are fully up to date and 1.14.24 still fails to install.

@manuseoane
Copy link

Same here on Safari 11.0.2, macOS 10.11.6.

Maybe an issue related to Safari >= 11.0.2?

@maciboy
Copy link

maciboy commented Jan 19, 2018

@gorhill
No updates are available for my system

@vassudanagunta
Copy link

@sheelgautam
Copy link

@vassudanagunta
Nope.
I meant that I could install other extensions from the Extensions Gallery. Ublock Origin is not on it. My earlier comment probably caused confusion.

@fostermarke
Copy link

Extension won't install here either. Clicking update in the prefpane does nothing and downloading to install manually produces the error dialog show earlier. This is Safari 11.0.2 on both 10.13.2 and 10.11.6.

@dnblankedelman
Copy link

I have yet to try and reproduce this, but I am curious (in an attempt to help the developers who I really appreciate): when this fails, any messages at all in the OSX console, Safari web inspector/console, some other log source? Any useful info from Xcode or the Extension builder in the Develop menu (have to turn it on in preferences)?

Just wondering if Safari logs any more useful info any place else beyond a "it be broke" dialogue.

@mamedker
Copy link

Same there but nevertheless, thanks for the great work !

Hope it'll be fixed soon

@sidneys
Copy link

sidneys commented Jan 19, 2018

same here, neither update nor fresh install works.

@iAYMANi
Copy link

iAYMANi commented Jan 19, 2018

Same issue here

@timbuktu234
Copy link

timbuktu234 commented Jan 19, 2018

Exactly same problem as original poster. Extension fails to install.

Running macOS 10.13.2 (17C205)
Safari Version 11.0.2 (13604.4.7.1.6)
on MacBook Pro Mid 2014

screen shot 2018-01-19 at 10 52 23 am

@SLGiHub
Copy link

SLGiHub commented Jan 20, 2018

Yeah same here after following manual install instructions, fails to install

@marcothuemmler
Copy link

marcothuemmler commented Jan 20, 2018

./tools/make-safari.sh all and installing through the Extension builder seems to have done the trick for me.
bildschirmfoto 2018-01-20 um 09 31 17
bildschirmfoto 2018-01-20 um 09 21 33
bildschirmfoto 2018-01-20 um 09 22 05

@ghost
Copy link

ghost commented Jan 20, 2018

Can it be repackaged and added to releases?

@volcbs
Copy link

volcbs commented Jan 20, 2018

@MEGADR01D You need to have the certificate, but then it won't be upgradeable to the next version (IIRC). So @el1t should be the one who does it.

@CasualDeveloper
Copy link

Just wanted to say I'm having this issue too

@accolon
Copy link

accolon commented Jan 20, 2018

./tools/make-safari.sh all and installing through the Extension builder seems to have done the trick for me.

It even works if you extract the downloaded uBlock0.safariextz (with xar -xf) and then install it through Extension Builder. It's a shame Safari doesn't provide any additional information what's wrong, or I'm looking in the wrong places.

Besides, the problem exists on both Safari versions right before and after the Meltdown/Spectre patches, while build 1.14.14 still works.

@maciejtarmas
Copy link

Safari shows a pending update, but you can click the "Update" button to death and nothing happens.

Trying to install the new version manually results in the message like in the OP's bug report.

If only Firefox was as battery efficient as Safari, I'd switch in a sec.

Apple is going downhill with their QA lately. I'm seriously considering switching to Windows or Linux after years of being an Apple loyalist.

macOS 10.13.2
Safari 11.0.2 (13604.4.7.1.6)
screen shot 2018-01-20 at 23 02 07

@ghost
Copy link

ghost commented Jan 20, 2018

Hello,
I can confirm the update is showing as per maciejtarmas, looks like there is no action on the 'Update' button. However this is a issue with the signature. Safari is throwing a:

"CSSM Exception: -2147415734 CSSMERR_CSP_VERIFY_FAILED" in the console.app

safari-ublock-update-log.txt

@volcbs
Copy link

volcbs commented Jan 21, 2018

^ from this https://developer.apple.com/library/content/technotes/tn2318/_index.html

If OCSP and CRL checking are temporarily turned off (in Keychain Access > Preferences > Certificates) and this resolves the Xcode build, reinstall Xcode (to restore its own signature) and also ensure there are no network connectivity issues on the Mac that is running Xcode.

@PTDennis
Copy link

Another one having the same issue. Hope the dev will release an update soon.

@vassudanagunta
Copy link

vassudanagunta commented Jan 21, 2018

FYI: Please everyone remember @el1t does this port of uBlock Origin to Safari all on his own time, unpaid, and with little credit. And he's clearly busy. And no one else is stepping up to help maintain the port. On top of that some other user made his life more difficult (#69) and is the reason the Extension Gallery version is a problem.

(feel free to vote up #71 to show some love)

@ghost
Copy link

ghost commented Jan 21, 2018

Excellent point @vassudanagunta . We've been using 1.14.14 for months so we can wait for x.24 to get sorted at elt's convenience while still browsing with a good extension.

@nidstigator
Copy link

Adding my voice to these appreciating all the work @el1t is doing!

The $99/year fee alone has been the reason most devs stayed away from porting uBlock to Safari.

@gingerbeardman
Copy link

Also getting this.

Could it be released to the fact that it has also disappeared from the Safari Extensions Gallery?

@hmage
Copy link

hmage commented Jan 22, 2018

I'm getting this too.

No xcode, OSX 10.13.2, Safari 11.0.2 (13604.4.7.1.3).

uBlock 1.14.14 installs fine even after removing it and adding it back.

@agottardo
Copy link

Getting this too on 11.0.2 (13604.4.7.1.6).

@gingerbeardman
Copy link

Thanks for the info @vassudanagunta ! I had no idea the Safari extension gallery version was unauthorised.

@el1t
Copy link
Owner

el1t commented Jan 22, 2018

Sorry everyone, looks like the build script produced a bad extension. I've rebuilt it using Safari's extension builder, and it installs for me: uBlock0.safariextz.zip (unzip first). I'll update the release if the issue is fixed.

The build might have failed due to a renewed certificate or the archive signing method becoming outdated—either way, I'll make sure to verify installation works next time.

@dart-h-vader
Copy link

@maciejtarmas Though I acknowledge there is an issue with the extension, it is for the benefit of the users that the extension is failing to install. Granted, uBlock is a genuine piece of software but the signing is an essential step for keeping malicious extensions at bay.

@ghost
Copy link

ghost commented Jan 22, 2018

It auto-updated from 1.14.14 for me after your post. Thanks for your work @el1t

@gingerbeardman
Copy link

update from within safari worked for me just now. thanks

@el1t
Copy link
Owner

el1t commented Jan 22, 2018

Great! I'll close this issue since it looks fixed.

@el1t el1t closed this as completed Jan 22, 2018
@timbuktu234
Copy link

timbuktu234 commented Jan 22, 2018

Extension working now, thank you!

@volcbs
Copy link

volcbs commented Jan 23, 2018

Thank you!

@lsunsi
Copy link

lsunsi commented Jan 23, 2018

Thank you dude!

@maelcum
Copy link

maelcum commented Jan 23, 2018

Thank you!

@ghost
Copy link

ghost commented Jan 27, 2018

@nidstigator

The $99/year fee alone has been the reason most devs stayed away from porting uBlock to Safari.

Apple Developer Program Membership Fee Waivers Now Available just as a note

and thanks el1t for your work !

@ruchernchong
Copy link

ruchernchong commented Jan 28, 2018

@monouser7dig

We’re pleased to announce that Apple Developer Program membership is now available at no cost for eligible organizations. Nonprofit organizations, accredited educational institutions, and government entities based in the United States

@volcbs
Copy link

volcbs commented Jan 28, 2018

based in the United States

Could create pseudo-organization for ublock, but sadly gorhill is a Canadian.

@accolon
Copy link

accolon commented Apr 22, 2018

At least for me, the problem is back for the very recent v1.16.0. Anybody else?

EDIT for clarification: The downloaded .safariextz from the "Releases" section gives the "Safari can’t install this extension" described above.

@ruchernchong
Copy link

@accolon if you are referring to the update not reflecting in the extensions, then yes. I am having the same problem as you right now.

@fostermarke
Copy link

I have the same problem. Downloaded the extension and click to install produces a pop-up with:

Safari can’t install this extension
An error occurred while installing the extension “uBlock Origin”.

@maciboy
Copy link

maciboy commented Apr 22, 2018

For me it worked seamlessly 😁
Safari settings and the uBlock Origin menu itself reflect the update, saying 1.16.0
(Safari 11.0.3)

@fostermarke
Copy link

Have just tried again but manually removed the previous version first.
Now success!

@marcothuemmler
Copy link

Had the same problem. Removing the older version fixed it for me, too.

@ghost
Copy link

ghost commented May 7, 2018

Safari extension store is still serving the old 1.15.4 version. Are there any problems with the store authorisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet