Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 126.0.6478.114 to Chromium 126.0.6478.126 #39329

Closed
emerick opened this issue Jun 24, 2024 · 8 comments · Fixed by brave/brave-core#24358
Closed

Upgrade from Chromium 126.0.6478.114 to Chromium 126.0.6478.126 #39329

emerick opened this issue Jun 24, 2024 · 8 comments · Fixed by brave/brave-core#24358
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.67.x - Release #4

Comments

@emerick
Copy link
Contributor

emerick commented Jun 24, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/126.0.6478.114..126.0.6478.126?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jun 24, 2024
This was referenced Jun 24, 2024
Merged
Merged
Merged
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 25, 2024
@kjozwiak
Copy link
Member

The above requires 1.67.123 or higher for 1.67.x verification 👍
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave	1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit) 
Revision	fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS	Linux

image
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 10 Version 22H2 (Build 19045.4529)

image
@LaurenWags
Copy link
Member

LaurenWags commented Jun 25, 2024 •
edited
Loading

Verified with

Brave	1.67.123 Chromium: 126.0.6478.126 (Official Build) (arm64) 
Revision	fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS	macOS Version 14.5 (Build 23F79)

Screenshot 2024-06-25 at 7 55 23 AM

Verified with

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (x86_64)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | macOS Version 13.6.7 (Build 22G720)
Screenshot 2024-06-25 at 9 34 09 AM
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit) 
Revision	fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2024-06-25 at 10 06 56 AM Screenshot 2024-06-25 at 10 10 31 AM
@LaurenWags LaurenWags mentioned this issue Jun 25, 2024
Closed
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit) 
Revision	fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2024-06-25 at 11 20 38 AM Screenshot 2024-06-25 at 11 20 45 AM
@kjozwiak kjozwiak mentioned this issue Jun 25, 2024
Closed
@kjozwiak kjozwiak added the OS/iOS Fixes related to iOS browser functionality label Jun 25, 2024
@kjozwiak kjozwiak mentioned this issue Jun 25, 2024
Closed
9 tasks
@hffvld
Copy link
Contributor

hffvld commented Jun 26, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.67 (123)
BraveCore: 1.67.123 (126.0.6478.126)
1 2
1 2
@hffvld
Copy link
Contributor

hffvld commented Jun 26, 2024

Verified on iPad Air using version(s):

Device/OS: iPad Air / iPadOS 16.7.2
Brave build: 1.67 (123)
BraveCore: 1.67.123 (126.0.6478.126)
1 2
1 2
@Uni-verse Uni-verse mentioned this issue Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
8 participants
@kjozwiak @emerick @Uni-verse @LaurenWags @GeetaSarvadnya @mkarolin @brave-builds @hffvld