Remove Brave Swap Fee

[StephenHeaps]

Description

We should remove Brave Fee for Swaps on all platforms. WebUI for desktop & Android, native for iOS. Implementation TBD.

Steps to reproduce

1. Fetch a price quote in swap
2. Brave Fee label is shown with a percentage beside it

Actual result

Brave fee is shown for swaps (Ethereum & Solana)

Expected result

No Brave fee for swaps (Ethereum or Solana)

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

All

Android device

All

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

No response

[kjozwiak]

The above requires 1.66.120 or higher for 1.66.x verification 👍

[srirambv]

Verification passed on

Brave	1.66.120 Chromium: 125.0.6422.165 (Official Build) (64-bit)
Revision	bd9a9589253e659c93a1c77eb9a3974525a80312
OS	Windows 11 Version 23H2 (Build 22631.3672)

• Verified steps from brave/brave-core#23960
• Verified Brave fee is set to 0% on all Swap transactions

38566.mp4

[srirambv]

Verification passed on Google Pixel 8 with Android 14 running 1.66.120 x64 build

• Verified steps from brave/brave-core#23960
• Verified Brave fee is set to 0% on all Swap transactions

38566.mp4

[srirambv]

Verification passed on iPhone 13 running 1.66.1 (120)

• Verified steps from brave/brave-core#23960
• Verified Brave fee is set to 0% on all Swap transactions

38566.mp4

[kjozwiak]

Moved this into the 1.67.x milestone as we're not going to be releasing another 1.66.x with C125. We'll be releasing C126 via 1.67.x on June 13th. Added so it can be included in the 1.67.x release notes.

However, keep in mind that the above was released on Android via 1.66.x - Release #6 so there's no need to add the above into the release notes for Android. CCing @hffvld.