Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat: Integrate search events from the Conversation API #38155

Closed
petemill opened this issue May 8, 2024 · 2 comments · Fixed by brave/brave-core#23501
Closed

AI Chat: Integrate search events from the Conversation API #38155

petemill opened this issue May 8, 2024 · 2 comments · Fixed by brave/brave-core#23501
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@petemill
Copy link
Member

petemill commented May 8, 2024

The Conversation API is now returning events related to Brave Search. We can implement the designed statuses:

  • Search in progress
image
  • Search queries used to generate a response
image
@petemill petemill added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 8, 2024
@petemill petemill self-assigned this May 8, 2024
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include browser-ai labels May 8, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 8, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 23, 2024

Verification PASSED` using

Brave | 1.67.92 Chromium: 125.0.6422.76 (Official Build) beta (64-bit)
-- | --
Revision | d751d2edf40b466560aaeecc4c4919041f41c20d
OS | Windows 11 Version 23H2 (Build 22631.3593)
  1. Installed 1.67.92
  2. launched Brave with --enable-logging=stderr --v=2 --enable-features=AIChat:conversation_api/true --env-leo=staging --env-ai-chat.bsg-dev --env-ai-chat-premium.bsg.dev--env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. logged in with or without Leo premium user
  4. opened brave://settings/leo-assistant in a new tab and selected models as below
  5. verified with all four models with a prompt What are some of the top tourist attractions in Ireland?
Mixtral - PASSED
  • Verified with Premium & Free subscriptions as well.
  • Confirmed Search in progress status returned with Improving answer with Brave Search... text shown briefly before search results returned
  • Confirmed Search queries used to generate a response status returned with `Improved answer searching for "top tourist attractions in Ireland", "most popular tourist destinations in Ireland". are shown
example example
image image
Claude Instant - PASSED
  • Confirmed Search in progress status returned with Improving answer with Brave Search... text shown briefly before search results returned
  • Confirmed Search queries used to generate a response status returned with `Improved answer searching for "top tourist attractions in Ireland". are shown
example example example
image image image
Claude 3 Haiku - PASSED
  • Confirmed Search in progress status returned with Improving answer with Brave Search... text shown briefly before search results returned
  • Confirmed Search queries used to generate a response status returned with `Improved answer searching for "top tourist attractions in Ireland". are shown
example example example example
image image image image
Claude 3 Sonnet - PASSED
  • Logged in as Premium user
  • Confirmed Search in progress status returned with Improving answer with Brave Search... text shown briefly before search results returned
  • Confirmed Search queries used to generate a response status returned with `Improved answer searching for "top tourist attractions in Ireland". are shown
example example example example
image image image image
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 12, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.67.113 Chromium: 126.0.6478.56 (Official Build) (64-bit) 
Revision	2c6c9c73e7382e94dd9f7327dff55cb1fe56ff59
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured improved answer with Brave Search loader is shown for queries.
  • Ensured search integration is working with all models for free and premium users.
  • Ensured chat responses are labelled using Improved answer searching....
Mixtral Haiku Sonnet Llama
Screenshot 2024-06-12 at 11 09 51��AM Screenshot 2024-06-12 at 11 11 08 AM Screenshot 2024-06-12 at 11 17 10 AM Screenshot 2024-06-12 at 11 27 38 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
5 participants