Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit icon should be same in all locations #38077

Closed
srirambv opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23477
Closed

Deposit icon should be same in all locations #38077

srirambv opened this issue May 6, 2024 · 1 comment · Fixed by brave/brave-core#23477
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Milestone
1.67.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented May 6, 2024

Description

Deposit icon should be same in all locations.

Steps to Reproduce

  1. Open brave://wallet/crypto/accounts
  2. Click on more menu shows QR code for deposit
  3. Click on any account to load account details page
  4. Click on more menu shows different deposit icon

Actual result:

Deposit.Icon.mp4

Expected result:

Should have the same icon

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.66.97 Chromium: 124.0.6367.118 (Official Build) beta (64-bit)
Revision 94909f2aaefd7a8137c8b4fa27235378e79231e3
OS Windows 11 Version 23H2 (Build 22631.3527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel
@srirambv srirambv mentioned this issue May 6, 2024
Closed
@Douglashdaniel Douglashdaniel self-assigned this May 6, 2024
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label May 7, 2024
@Douglashdaniel Douglashdaniel mentioned this issue May 7, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 8, 2024
@srirambv srirambv mentioned this issue May 17, 2024
Closed
@srirambv
Copy link
Contributor Author

Marking as QA/No. This issue is superseded by #38403
@srirambv srirambv added QA/No and removed QA/Yes labels May 20, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
3 participants
@srirambv @Douglashdaniel @brave-builds