Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiFi transaction JSON response must be sanitized #37930

Closed
onyb opened this issue Apr 29, 2024 · 0 comments · Fixed by brave/brave-core#23315
Closed

LiFi transaction JSON response must be sanitized #37930

onyb opened this issue Apr 29, 2024 · 0 comments · Fixed by brave/brave-core#23315
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Milestone
1.67.x - Release

Comments

@onyb
Copy link
Member

onyb commented Apr 29, 2024

LiFiTransactionResponse contains a numeric chainId field currently. The recommended way to parse JSON responses is to first convert all numeric values to strings and then parse the fields accordingly.

Ref: brave/brave-core@cb383f6#r1548845510
@onyb onyb added QA/No release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/swap labels Apr 29, 2024
@onyb onyb self-assigned this Apr 29, 2024
@onyb onyb mentioned this issue Apr 29, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 30, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Jun 14, 2024
Closed
@hffvld hffvld mentioned this issue Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
2 participants
@onyb @brave-builds