Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token list alignment needs adjusted in Wallet #37525

Closed
Douglashdaniel opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23040
Closed

Token list alignment needs adjusted in Wallet #37525

Douglashdaniel opened this issue Apr 11, 2024 · 1 comment · Fixed by brave/brave-core#23040
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@Douglashdaniel
Copy link

Description

Currently the Token List alignment is not consistent on the Wallet Page and Wallet Panel.

Steps to Reproduce

Actual result:

image

Expected result:

Everything should have the same horizontal padding.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 11, 2024
@Douglashdaniel Douglashdaniel self-assigned this Apr 11, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Apr 11, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 12, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
Revision d01060f5ec155e6eb64a335203663a29c0e5d81f
OS Windows 11 Version 23H2 (Build 22631.3593)
37525.mp4
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
3 participants
@srirambv @Douglashdaniel @brave-builds