Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-AMP shouldn't apply for non-HTML pages #37406

Closed
ShivanKaul opened this issue Apr 8, 2024 · 2 comments · Fixed by brave/brave-core#22978
Closed

De-AMP shouldn't apply for non-HTML pages #37406

ShivanKaul opened this issue Apr 8, 2024 · 2 comments · Fixed by brave/brave-core#22978
Assignees
@ShivanKaul
Labels
bug OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/de-amp QA Pass - Android ARM QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@ShivanKaul
Copy link
Collaborator

We shouldn't attempt to De-AMP pages that are not HTML. This was reported internally.
@ShivanKaul ShivanKaul added bug priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop privacy/de-amp labels Apr 8, 2024
@ShivanKaul ShivanKaul self-assigned this Apr 8, 2024
@ShivanKaul ShivanKaul mentioned this issue Apr 9, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 11, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.67.52 Chromium: 124.0.6367.91 (Official Build) nightly (x86_64)
-- | --
Revision | a368a1ab342f0a5d4dee4db3f2699f7d02579247
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.67.52
  2. launched Brave
  3. loaded https://shivankaul.com/brave/de-amp/test-content-type-text.txt
  4. confirmed Auto-redirect AMP pages in brave://settings/privacy

Confirmed page rendered as-is, rather than redirecting to brave.com

example example
Screen Shot 2024-04-30 at 3 01 35 PM Screen Shot 2024-04-30 at 3 04 37 PM
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 3, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 4, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.023.B4 release-keys
Brave build: 1.67.100
Chromium: 125.0.6422.112 (Official Build) beta (64-bit)

STEPS:

  1. Launch Brave
  2. Go to https://shivankaul.com/brave/de-amp/test-content-type-text.txt
  3. Verify

ACTUAL RESULTS:

1 2 3
1 2 3
@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 4, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Jun 14, 2024
Closed
@hffvld hffvld mentioned this issue Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/de-amp QA Pass - Android ARM QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
5 participants
@stephendonner @ShivanKaul @rebron @brave-builds @hffvld