Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme causes filters to look disabled #37173

Closed
srirambv opened this issue Mar 28, 2024 · 4 comments · Fixed by brave/brave-core#23195
Closed

Dark theme causes filters to look disabled #37173

srirambv opened this issue Mar 28, 2024 · 4 comments · Fixed by brave/brave-core#23195
Assignees
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Dark theme causes filters to look disabled

Steps to Reproduce

  1. Set browser theme to dark
  2. Open Wallet and click on portfolio filters
  3. Select any dropdown, looks disabled but can still select to change filters

Actual result:

brave_FhtRY5GBl9 brave_hdlpqA9gHF

Expected result:

Better looking UI on dark theme

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @kleantzogu @Douglashdaniel @josheleonard

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 28, 2024
@Douglashdaniel
Copy link

I think this is a leo issue since this is using the Dropdown component directly from @brave/leo/react/dropdown.
cc: @fallaciousreasoning @petemill

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 29, 2024
@fallaciousreasoning
Copy link

This looks like it could be using the colors from the light theme - if you add a data-theme="dark" to the body (or any parent element of the dropdown) does it look better?

This is how the component should look in dark mode:
image

@Douglashdaniel Douglashdaniel self-assigned this Apr 22, 2024
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Apr 22, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 22, 2024
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.67.92 Chromium: 125.0.6422.76 (Official Build) beta (64-bit)
Revision d751d2edf40b466560aaeecc4c4919041f41c20d
OS Windows 11 Version 23H2 (Build 22631.3593)
  • Verified steps from brave/brave-core#23195
  • Verified Portfolio filters are properly visible when browser is set to Dark theme
37173.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
6 participants