-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Media Router (cast) feature by default on Desktop #37109
Labels
Projects
Milestone
Comments
24 tasks
Verification
New InstallCase 1: New profile => Media Cast is ON
UpgradeCase 2: Existing profile has Media Cast OFF => nothing changes
Confirmed
|
example | example | example | example | example |
---|---|---|---|---|
Case 3: Existing profile has Media Cast ON => nothing changes
- installed
1.66.115
- launched Brave
- opened
brave://settings/extensions
- toggled
On
Media router
- closed the browser and renamed the
profile to brave-browser-beta
- installed 1.67.94
- launched Brave
- opened
brave://settings/extensions
- Confirmed
Media Router
stayed enabled - Confirmed
Cast
option in the Share menu is shown
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
Verification
|
example | example | example | example | example |
---|---|---|---|---|
Upgrade - PASSED
Case 2: Existing profile has Media Cast OFF => nothing changes
Steps:
- installed
1.66.115
- launched Brave
- opened brave://settings/extensions
- verified
Media Router
is disabled by default - closed the browser and renamed the profile to
Brave-Browser-Beta
viamv /Users/sdonner/Library/Application\ Support/BraveSoftware/Brave-Browser /Users/sdonner/Library/Application\ Support/BraveSoftware/Brave-Browser-Beta
- installed
1.67.100
- launched Brave
- opened
brave://settings/extensions
- confirmed
Media Router
was stillDisabled
/OFF
- loaded a video on
youtube.com
- click on the
Share this page
icon in the URL bar
Confirmed no Cast
options
example | example | example | example | example | example |
---|---|---|---|---|---|
Case 3: Existing profile has Media Cast ON => nothing changes
Steps:
- installed
1.66.115
- launched Brave
- opened
brave://settings/extensions
- toggled
On
Media Router
- restarted Brave
- closed the browser and renamed the profile to
Brave-Browser-Beta
viamv /Users/sdonner/Library/Application\ Support/BraveSoftware/Brave-Browser /Users/sdonner/Library/Application\ Support/BraveSoftware/Brave-Browser-Beta
- installed
1.67.100
- launched Brave
- opened
brave://settings/extensions
- confirmed
Media Router
wasEnabled
/ON
Confirmed I saw my usual in-home casting devices in the Share this page
-> Cast
dialog
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We had previously disabled Media Router by default on Desktop (but enabled by default on Android). The Media Router feature (toggleable in brave://settings/extensions) allows a user to cast a Brave tab to a device such as a smart TV. During privacy review, we'd caught that when the Media Router feature was on, outgoing SSDP packets used the Brave user agent instead of the Chrome one like we do on the Web. This was fixed in #18017.
At this point I don't think there's much benefit to keeping this important feature disabled by default. We should enable by default, and let privacy-conscious users turn it off.
The text was updated successfully, but these errors were encountered: