Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simple markdown to render some responses in a nicer way #35891

Closed
bbondy opened this issue Feb 8, 2024 · 4 comments · Fixed by brave/brave-core#23053
Closed

Use simple markdown to render some responses in a nicer way #35891

bbondy opened this issue Feb 8, 2024 · 4 comments · Fixed by brave/brave-core#23053
Assignees
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Feb 8, 2024

We need simple markdown being used to make responses like this look a lot better.

Screenshot 2024-02-08 at 8 57 47 AM (1)

  • Do we need any prompt changes?
  • What do we do for code formatting, can we do something similar?
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 8, 2024
@mattmcalister mattmcalister added browser-ai priority/P3 The next thing for us to work on. It'll ride the trains. design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Feb 8, 2024
@petemill
Copy link
Member

petemill commented Feb 8, 2024

  • Tables
  • Headings
  • Bold, Italic
  • Indentation for lists (bullet / numbered)

Headings should allow inline code strings but not code blocks.
Mardown shouldn't be parsed inside code blocks.
Possibly we shouldn't allow links to get made in to an <a>.
We definitely shouldn't allow html, embeds, etc.

@aguscruiz aguscruiz removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Feb 23, 2024
@nullhook nullhook self-assigned this Apr 9, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 26, 2024
@stephendonner
Copy link

stephendonner commented Apr 30, 2024

Verification PASSED using

Brave | 1.67.52 Chromium: 124.0.6367.91 (Official Build) nightly (64-bit)
-- | --
Revision | a368a1ab342f0a5d4dee4db3f2699f7d02579247
OS | Windows 10 Version 22H2 (Build 19045.4355)

Case 1: Ensure Correct Rendering

Code blocks ✅

Prompt: write me a finite state machine using C++

Prompt: can you help me write HTML code which outputs a table with 3 columns and two rows?

example example
image image

Inline code ✅

image

{Paragraphs (p), Bold text, Heading, Lists} ✅

example example
image image

Numbered ✅

example example
image image

Bulleted ✅

image

Case 2: Ensure the following are NOT rendered

{Links, Tables, Images} ✅

Prompt: what does Superman look like? Can you provide me with an image?

image

Case 3: Ensure the typing cursor is visible with paragraphs and lists

Caret/Typing cursor

image

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 30, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 30, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.67.98 Chromium: 125.0.6422.112 (Official Build) beta (64-bit) 
Revision	9434daa5e8d2aceabb9cce574ab39429f2923b9b
OS	Android 13; Build/TP1A.220624.014; 33; REL
Correct Rendering
  • Code blocks
  • Inline code
  • Paragraphs (p)
  • Bold text
  • Headings
  • Lists
Example Example Example Example Example
Screenshot 2024-05-30 at 11 38 01 AM Screenshot 2024-05-30 at 12 34 25 PM Screenshot 2024-05-30 at 12 03 24 PM Screenshot 2024-05-30 at 12 05 27 PM Screenshot 2024-05-30 at 11 53 54 AM
Not Rendered
  • Tables
  • Links
  • Images
Example Example Example
Screenshot 2024-05-30 at 1 11 06 PM Screenshot 2024-05-30 at 12 35 58 PM Screenshot 2024-05-30 at 1 20 22 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
8 participants