Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme preview: Style variations exceed container width, creating horizontal scrollbar #141

Closed
Clorith opened this issue Jun 19, 2024 · 1 comment

Comments

@Clorith
Copy link
Member

Clorith commented Jun 19, 2024

Describe the bug
The style variations in the theme previewer uses a grid display, but the two column layout causes a horizontal scroll bar.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wordpress.org/themes/twentytwentyfour/preview/
  2. Observe the sidebar with style variations and patterns, and a horizontal scrollbar at the bottom.

Expected behavior
The style variation buttons should either shrink in size to fit within the container, or collapse into a single column.

Screenshots
Screenshot displaying the horizontal scrollbar in the left hand sidebar area with the Google Chrome browser

Desktop (please complete the following information):

  • OS: Windows 10 (22H2)
  • Browser: Google Chrome
  • Browser Version: 125.0.6422.142
  • Browser: Microsoft Edge
  • Browser Version: 126.0.2592.61
  • Browser: Firefox
  • Browser Version: 127.0.1

Additional context
Tested on relatively large resolution desktop monitors with 1920px and 2560px widths. This appears to happen due to the vertical scrollbar in the left hand sidebar being present, when switching to responsive mode in dev tools, where the scrollbar behaves like on a non-desktop device, or as is the default on Mac's, the horizontal scroll is not there.

@ryelle ryelle closed this as completed in 90ed7b5 Jun 19, 2024
@ryelle
Copy link
Collaborator

ryelle commented Jun 19, 2024

I noticed this while fixing #140, so it'll be fixed on production shortly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants