Add breadcrumbs to all pages

[marko-srb]

Here are the breadcrumbs, and they should be found on 'search results' as well...

Taxonomy for search results: "Home / Showcase / Search results"

CC: @jasmussen

[ryelle]

Home / Showcase / Search results

Technically "home" and "showcase" would be the same URL (https://wordpress.org/showcase/), do you mean for Home to be wordpress.org?

This is different from the developer reference, which uses "Home" to mean developer.wordpress.org.

[ryelle]

This also adds some duplicate links pretty close to each other— the Showcase link the local nav bar (black background) would be the same as the middle breadcrumb, and if "Home" is meant to be wp.org, that's the same as the W logo.

[ryelle]

This issue also made me think about how these bars should all work on scroll, so I left a comment about that over on this issue WordPress/wporg-mu-plugins#465

[jasmussen]

Thanks for the ping. I believe the breadcrumbs as Francisco designed them has Home being the main index for that page. So it should likely be:

Showcase
Home / Tags

in the example above. And in this case, both "Showcase" and "Home" links would link to the same place.

[marko-srb]

Oh, my bad then. Apologies.

Joen's suggestion seems right. I am not sure why we have 'Showcase' one on top another. It makes sense if this stays sticky though, while top nav doesn't.

Anyhow, let's proceed that way and chat with Francisco about your comment Kelly, once he's back:

Thanks!

[ryelle]

Okay, I started to implement this and I'd like to check in.

To start, here are some easy ones, I think these are all fine.

All sites page, no filters

A search result (the wordpress meaning of search)

The submission page

A single site

---

These are not handled by your mockups, but I've used my judgement:

Archive, one category selected

Archive, two filters applied

---

These are probably wrong…

"Browse" is probably not a great title for this page, but is contains more than just tags so I don't think "Tags" works either. This can be changed in the site content though, it's not a blocker for the code.

The Thanks page should probably not have this? Or it should be dark. Should the "current page" be faked to be the submission page?

Any conversation about stickiness should stay in the other issue, though I was hoping to find a solution before my sabbatical, which is before Francisco gets back.

[jasmussen]

In general, looks good.

This is more of a note for @pablohoneyhoney, I think the individual site feature loses a little character with the white bar above it. I also think it's acceptable and the consistency of the bar helps, so I don't know that there's an easy fix there, outside of maybe just not showing the breadcrumb bar on this page? Or maybe having a dark version?

"Browse" is probably not a great title for this page, but is contains more than just tags so I don't think "Tags" works either. This can be changed in the site content though, it's not a blocker for the code.

Could it be "Archive"?

The Thanks page should probably not have this? Or it should be dark. Should the "current page" be faked to be the submission page?

Related to the single feature, I wonder: is it possible for us to have an inverted breadcrumb bar, same color as the 1st row, just for the single site pagess and the submission success page?

[ryelle]

Could it be "Archive"?

The "All sites" page is /archive/ (and done that way to match the current Showcase site), plus this isn't really an archive, just a list of terms. Maybe "Filters"?

is it possible for us to have an inverted breadcrumb bar, same color as the 1st row, just for the single site pagess and the submission success page?

Yes totally, that's what I was suggesting with the "should it be dark" question. I'll go with white text on charcoal-1 to match the local nav bar.

[jasmussen]

I'll defer to @marko-srb if he prefers light or dark, but I think dark could work for both of those.

"Filters" sounds good to me.

[marko-srb]

This one to close as #217 is fixing this one...

[ryelle]

Yes, when the PR #217 is merged, it will automatically close this issue.