Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single page: Can we move/align quote block on the left edge with other text #206

Closed
marko-srb opened this issue Sep 28, 2023 · 5 comments
Closed
Labels
[Component] Theme Templates, patterns, CSS

Comments

@marko-srb
Copy link

This alignment on the left, same as other paragraph elements should work well, as quote has different font, and the vertical line.

Screen Shot 2023-09-28 at 16 27 44

CC: @jasmussen

@jasmussen
Copy link

jasmussen commented Sep 28, 2023

Agreed. I'm assuming you are comparing it with this indentation:

Screenshot 2023-09-28 at 16 35 16

Note that this quote style is global, so it is also present in news, but curiously, the extra margin is not present there:

https://wordpress.org/news/2023/09/openverse-wins-the-2023-oeg-open-infrastructure-award/

Screenshot 2023-09-28 at 16 37 41

So this may be a local bug to fix here?

@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

News is not part of the shared system. That said, this example is & looks like News, so maybe something is going on with Showcase specifically.

Are the only changes the left margin & 1px border? If there are other changes, can you share a figma link so devs can reference it?

@ryelle ryelle added [Component] Theme Templates, patterns, CSS [Status] Needs Design Feedback Feedback is needed on an existing or new component labels Sep 28, 2023
@jasmussen
Copy link

Oh, thank you for the clarification. I assumed it was inherited as it seems close enough.

That said, I think a solid first step is to just add margin-left: 0; margin-right: 0; to the quote, right now it appears inherited from the browser:
Screenshot 2023-09-29 at 09 39 12
Screenshot 2023-09-29 at 09 39 16

@marko-srb
Copy link
Author

marko-srb commented Sep 29, 2023

Agree with Joen, we can do that as the first step and see if it works...

@ndiego
Copy link
Member

ndiego commented Oct 2, 2023

That said, I think a solid first step is to just add margin-left: 0; margin-right: 0; to the quote, right now it appears inherited from the browser:

Agree with Joen, we can do that as the first step and see if it works...

@ryelle I believe this can be fixed automatically by setting the Post Content block to "Inner blocks use content width" (i.e. "layout":{"type":"constrained"}). This adds the class is-layout-constrained which knocks out the browser margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
4 participants