Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the Featured category on the homepage #195

Closed
marko-srb opened this issue Sep 28, 2023 · 6 comments
Closed

Hide the Featured category on the homepage #195

marko-srb opened this issue Sep 28, 2023 · 6 comments

Comments

@marko-srb
Copy link

marko-srb commented Sep 28, 2023

We'd like to use this category only for practical reasons, so that we can manually affect which site goes to the home page. In that light, we'd love if this category is hidden from the home page.

Since we will temporarily add categories on the places of tags, featured shouldn't appear below site screenshots/post thumbnails, or at least not on the home/landing page.

Screen Shot 2023-09-28 at 11 44 45
@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

I thought we were only hiding it from within the site grid (which is tracked in #183). If the Featured category is "only for practical reasons", are you suggesting to remove it as a filter option entirely?

I'm not sure it makes sense to remove it just from the homepage filter, IMO those options should be consistent through the site.

@ndiego
Copy link
Member

ndiego commented Sep 28, 2023

@ryelle how hard would it be to hide Featured entirely? So it is just an internal category that is used for site sorting, but not something that the public sort/search by. That would solve this.

@ryelle
Copy link
Contributor

ryelle commented Sep 28, 2023

Sure, that would be easier than conditionally hiding it on some pages.

@ndiego
Copy link
Member

ndiego commented Sep 28, 2023

How hard would it be to hide Featured entirely? So it is just an internal category that is used for site sorting, but not something that the public sort/search by. That would solve this.

Sure, that would be easier than conditionally hiding it on some pages.

@marko-srb @jasmussen are you comfortable with this approach?

@jasmussen
Copy link

Sure. To me, Featured means it's in the homepage. So it's a utility class. I'm fine with hiding it.

@ndiego
Copy link
Member

ndiego commented Sep 28, 2023

Sure. To me, Featured means it's in the homepage. So it's a utility class. I'm fine with hiding it.

Thanks for confirmation. Let's move forward on this @ryelle 🙏

@ryelle ryelle closed this as completed in 9dceeae Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants