Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White bar still showing after the local nav bar #163

Closed
Tracked by #145
tellyworth opened this issue Jan 10, 2022 · 4 comments
Closed
Tracked by #145

White bar still showing after the local nav bar #163

tellyworth opened this issue Jan 10, 2022 · 4 comments
Labels
[Component] Theme Front-end help needed

Comments

@tellyworth
Copy link
Contributor

it's failing to show the intended "brush" shape:
Captura de ecrã 2022-01-04, às 10 58 03

@ryelle
Copy link
Contributor

ryelle commented Jan 10, 2022

This isn't meant to have the brush shape, the blue "categories" banner is meant to be up against the blue heading background:

Screen Shot 2022-01-10 at 3 47 15 PM

This comes from a margin added to site-header-offset

@iandunn
Copy link
Member

iandunn commented Jan 10, 2022

🤔 why was the margin added? we didn't have it before. is it something gutenberg is adding and we just need a margin: 0?

@ryelle
Copy link
Contributor

ryelle commented Jan 10, 2022

I believe it was a gutenberg change related to the block-gap feature. .wp-site-blocks > * + * { margin-top: var( --wp--style--block-gap ); } is overriding the existing site-header-offset { margin-top: 0; }

@shaunandrews
Copy link
Collaborator

This is fixed in #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Front-end help needed
4 participants