-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New landing page: Connecting influencers to affiliate programs ("Creator Connections") #433
Comments
I've built a first draft of this page in the Editor. It's very bare bones. If anyone from @WordPress/meta-design is available to add some finesse (does not have to be complex), that would be very much appreciated. The copy is mostly final, but any changes that will be made won't affect the layout. |
While I was trying to do the edits, old theme bugged me from having the section width as I set it in editor. See comparison below. Is there a way to switch this page to a new theme we use for Learn? Other elements in there, like hero section, are also done in manner of blocks we used for refresh. If there's an easy way to switch theme to the new one for this page, I should be able to handle all the further edits and creation of the page. Let me know. Thanks! |
Do you just mean the new design in general, or are you asking for something in the Learn theme in particular? This is the main site, so it would use the main theme like About, Download, and those subpages. I've set a temporary page template for now, so that it uses the correct width. It was already using the new theme, new pages just need an extra step for previews to look right. |
Thanks @ryelle ! This works now. What I mean by 'Learn' theme is the following. The 3 sections below are actually used from previous designs we used in new theme, or some old layouts, that are still in use, but polished.
I tried actually using 'home page cover' pattern for this, but it is merged component when I select it from patterns list, and it doesn't allow me to edit. How would I edit it if I use it?
— How can I re-use these elements in my page? Also does the 'column' block work for you? I get error when I use it. See ss below. ![]() ![]() Thanks! |
There are block styles you can use to get some of these effects, but we don't use reusable blocks/synced patterns because they're not translatable with the current system. Copying from other pages is probably the best approach if you don't want to build from scratch. There are probably multiple ways to get 1, cover block or columns. For 2, that's just columns, a heading, and a list block. Same with 3, just the list there has the "links" style to get the borders. Although, if 3 is expandable we do not have an existing style for that, and it might require dev work.
Yes, I'm seeing this too on all blocks, I'll take a look today. |
I've identified the block crashing issue as a bug in Gutenberg, reported it, and rolled back w.org to 18.8 — so you shouldn't have that problem anymore. |
Thanks @ryelle! I'll ping in case I need any access for reusing some blocks in the future. |
Quick summary
Find the full context, project scope, and discussion in the original issue (posted in the Marketing GitHub repo).
Notes
Given the simplicity of the layout and that this page will be in the new .org theme, we can build a first draft in the Editor (🎉) and then notify Design and Meta when ready for help fine-tuning.
The text was updated successfully, but these errors were encountered: