Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the Manage Attendees button if it is not permitted for the user #317

Closed
akirk opened this issue Jun 4, 2024 · 1 comment · Fixed by #318
Closed

Hide the Manage Attendees button if it is not permitted for the user #317

akirk opened this issue Jun 4, 2024 · 1 comment · Fixed by #318
Assignees

Comments

@akirk
Copy link
Member

akirk commented Jun 4, 2024

Clicking on Manage Attendees for an event I didn't create but I can edit (I suppose because of Admin on the site)

Screenshot 2024-06-04 at 11 21 54

gives me
Screenshot 2024-06-04 at 11 21 59

@trymebytes
Copy link
Collaborator

The reason for this is because the edit_translation_event_attendees cap check is missing here. However, we introduced the edit_translation_event_attendees cap to fix #242 .
Since we introduced the edit_translation_event_title and other similar capabilities for form fields, I believe we no longer need the edit_translation_event_attendees cap and we can make use of the edit_translation_event cap check to check if a user can edit attendees.

Therefore if a user can access the edit form, they should be able to edit the event attendees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants