Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress unavoidable Deprecated notices - Networking #1598

Closed
dd32 opened this issue Jul 11, 2024 · 3 comments · Fixed by #1660
Closed

Suppress unavoidable Deprecated notices - Networking #1598

dd32 opened this issue Jul 11, 2024 · 3 comments · Fixed by #1660

Comments

@dd32
Copy link
Member

dd32 commented Jul 11, 2024

PHP Deprecated: Hook http_api_transports is deprecated since version 6.4.0 with no alternative available. in /wordpress/wp-includes/functions.php on line 135

This hook deprecation notice is thrown and is included in all the bug reports, gaining Playground no benefits.

Unfortunately we're forced to use this deprecated hook to ensure SSL operations work without the kitchen-sink bundled. See #1504 for background.

We should suppress this deprecated hook notice somehow until https://core.trac.wordpress.org/ticket/37708 is resolved.

@bgrgicak
Copy link
Collaborator

We should suppress this deprecated hook notice somehow

We could add a exclude list to the logger.

@dd32
Copy link
Member Author

dd32 commented Jul 11, 2024

I was hoping there was a filter (or hook context) on the deprecated_hook_trigger_error hook, but there ain't (unlike the doing_it_wrong_trigger_error hook which does pass context), so a logger exclude list sounds reasonable.

@adamziel
Copy link
Collaborator

We suppress other warnings and notices in set_error_handler here:

set_error_handler(function($severity, $message, $file, $line) use($playground_consts) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment