Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

City landing pages aren't linked from anywhere #1223

Open
iandunn opened this issue Jan 24, 2024 · 4 comments
Open

City landing pages aren't linked from anywhere #1223

iandunn opened this issue Jan 24, 2024 · 4 comments

Comments

@iandunn
Copy link
Member

iandunn commented Jan 24, 2024

The Events site automatically creates landing pages for communities based on the year and topic. Those aren't linked to from anywhere, though. Should they be? If so, where? Should they be added to sitemap.xml etc?

For example:

Right now only one event is listed, but as there are more events in Rome, they'll be added to that.

Background:

@iandunn iandunn added this to the Events: Promotion milestone Jan 24, 2024
@StevenDufresne
Copy link
Contributor

I don't know if they should be from an SEO standpoint, they do appear to be broken however.

@iandunn
Copy link
Member Author

iandunn commented Jan 24, 2024

What looks broken to you?

@StevenDufresne
Copy link
Contributor

Maybe "broken" is an incorrect characterization, incomplete is probably better.

Here is what I see:
Screenshot 2024-01-26 at 9 47 00 AM

The obvious things on this page:

  • The search bar is out of place
  • The event list has no padding
  • If I search in the search bar, my focus is moved down to the list and i can't see what I'm typing
  • If I search for something like "nepal" and I know there is an event, I don't find anything (likely because it's only searching the rome events, but that isn't clear).

I think the better experience is that when we load those pages, we load the regular "Upcoming Events" page with the relevant country/date/etc.. filter applied.

@iandunn
Copy link
Member Author

iandunn commented Jan 26, 2024

Ah, you're right. I think we built this before we had a design, and before some of the architectural changes, and never circled back to update this.

I think the better experience is that when we load those pages, we load the regular "Upcoming Events" page with the relevant country/date/etc.. filter applied.

That's a great idea 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment