Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Spaces in every heading and paragraph #615

Closed
beafialho opened this issue Oct 11, 2023 · 4 comments · Fixed by #616
Closed

Spaces in every heading and paragraph #615

beafialho opened this issue Oct 11, 2023 · 4 comments · Fixed by #616
Labels
[Type] Bug Something isn't working

Comments

@beafialho
Copy link

Description

I'm seeing spaces before and after pretty much every heading and paragraph in the theme's patterns, including full page ones.

Step-by-step reproduction instructions

  1. Add a pattern.
  2. Notice the space before a heading and/or paragraph.

Expected behavior
There should be no extra spaces neither before nor after headings or paragraphs.

Screenshots

spaces.mp4
spaces_2.mp4

Environment info

  • Device: Apple M1 Max
  • OS: Ventura 13.4.1
  • Browser: Safari 16.5.2
@beafialho beafialho added the [Type] Bug Something isn't working label Oct 11, 2023
@carolinan
Copy link
Contributor

Good find,
this is probably another formatting issue, where new line breaks have been added, and should be easy to solve.

@beafialho
Copy link
Author

I just noticed this includes buttons in the patterns as well.

@MaggieCabrera
Copy link
Collaborator

Let's document this in the readme file on a section about formatting block markup for the future

@webmandesign
Copy link
Contributor

I think this happened during auto (?) formatting in #585.

When dealing with actual text content of a HTML tag (block), it should have no line break before and after.
For example, the

<summary>
	<?php echo esc_html_x( 'What is your process working in smaller projects?', 'Question on the details block', 'twentytwentyfour' ); ?>
</summary>

should turn into

<summary><?php echo esc_html_x( 'What is your process working in smaller projects?', 'Question on the details block', 'twentytwentyfour' ); ?></summary>

(Surely, you can have line breaks within <?php and ?> tags if needed.)

@luminuu luminuu linked a pull request Oct 11, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
4 participants