Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Post template visual improvements #612

Closed
beafialho opened this issue Oct 11, 2023 · 2 comments · Fixed by #614
Closed

Post template visual improvements #612

beafialho opened this issue Oct 11, 2023 · 2 comments · Fixed by #614

Comments

@beafialho
Copy link

I don't think the post template was looking like this previously, but if we look at the Figma designs, it currently has a lot of inconsistencies:

  • Tags block appears twice
  • The separator has the wrong color and it should be wide width
  • The "Comments" heading should not be there
  • There's a lack of padding in the "Leave a reply" section and in the post pagination

Here's a recording of what I mean and what should be adjusted:

post_template_adjustments.mp4
@luminuu
Copy link
Member

luminuu commented Oct 11, 2023

When I remember right the Comments header has to be there in order to ensure a correct heading structure to match the accessibility requirements. Is that correct @carolinan ?

I'll take a look at the other things you mentioned.

@MaggieCabrera
Copy link
Collaborator

I'm having a look at this, there are some regressions from the formatting refactor.

The comments title is there for accesibility reasons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants