Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Hidden patterns should use false instead of no for the inserter property #578

Closed
benoitchantre opened this issue Oct 7, 2023 · 1 comment
Closed

Hidden patterns should use false instead of no for the inserter property #578

benoitchantre opened this issue Oct 7, 2023 · 1 comment
Labels
[Type] Bug Something isn't working

Comments

@benoitchantre
Copy link

Description

For now, hidden pattern use the following declaration to prevent them to be found in the inserter: Inserter: no

Expected behavior

WordPress default themes should follow the official documentation

inserter (optional): By default, all patterns will appear in the inserter. To hide a pattern so that it can only be inserted programmatically, set the inserter to false.
source (optional): A string that denotes the source of the pattern.

https://developer.wordpress.org/block-editor/reference-guides/block-api/block-patterns/
@benoitchantre benoitchantre added the [Type] Bug Something isn't working label Oct 7, 2023
@benoitchantre benoitchantre mentioned this issue Oct 7, 2023
Closed
@benoitchantre
Copy link
Author

As mentioned by @carolinan, yes / no are the expected values when patterns are saved in the patterns directory.

https://make.wordpress.org/core/2022/05/02/new-features-for-working-with-patterns-and-themes-in-wordpress-6-0/
@benoitchantre benoitchantre closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
1 participant
@benoitchantre