Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Page Template: Adjust spacing between title and content #565

Closed
beafialho opened this issue Oct 4, 2023 · 9 comments
Closed

Page Template: Adjust spacing between title and content #565

beafialho opened this issue Oct 4, 2023 · 9 comments

Comments

@beafialho
Copy link

Testing different scenarios on the page template, I notice that there's a spacer between the title and featured image. This should be removed and perhaps a margin should be applied to the featured image and post content blocks instead for a better result in different occasions. In the videos below I deleted the spacer and applied 30px margin to the content and featured image:

Left aligned long text, no featured image

page_template_spacing.mp4

With featured image

page_template_spacing_3.mp4

Short text, centered

page_template_spacing_2.mp4
@carolinan
Copy link
Contributor

We were earlier asked to use the page as the example of the correct spacing, so the other templates are modelled after this template. So that would mean they are basically all wrong and needs to be re-reviewed.

@carolinan
Copy link
Contributor

I just mean that they need to be re-checked so it is not missed.

@carolinan
Copy link
Contributor

The closest spacing preset would be preset 20, min 24px, so I guess we will be using the 30 pixels then.

				{
					"name": "2",
					"size": "min(1.5rem, 2vw)",
					"slug": "20"
				},
@carolinan
Copy link
Contributor

carolinan commented Oct 6, 2023

OK, I found that the post content block does not have a margin or padding support (As in, the block editor has not enabled these settings). Do we want to try to add it to all post content blocks in theme.json? If we do, users can't override it without custom CSS.

@carolinan
Copy link
Contributor

I tried the theme.json approach and it does not look great.

Here is a what a page without featured image would look like:
Page template with margin top on the content block.

And here is what a post without featured image would look like:
Post template with margin top on the content block

@carolinan
Copy link
Contributor

Can you try a design where the bottom spacing is on the post title, instead of top margin being on the featured image and content?

@beafialho
Copy link
Author

Sorry about the delay in replying.

Can you try a design where the bottom spacing is on the post title, instead of top margin being on the featured image and content?

You mean trying bottom spacing to the title just for the page template, right? Or this will be reflected in all others?

@luminuu
Copy link
Member

luminuu commented Oct 12, 2023

@beafialho I think @carolinan referred to doing this for the page template which then serves as a base for all other templates and they need to be re-viewed.

@beafialho
Copy link
Author

If it will be reflected in all others, we can just close this issue. I do not want to mess up any other places.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants