Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Quote (Plain): Improve appearance #439

Closed
beafialho opened this issue Sep 20, 2023 · 7 comments · Fixed by #606
Closed

Quote (Plain): Improve appearance #439

beafialho opened this issue Sep 20, 2023 · 7 comments · Fixed by #606
Labels
[Status] Help Wanted Extra attention is needed

Comments

@beafialho
Copy link

Currently the Plain Quote is looking a bit awkward. Let's improve its appearance by setting it to use System font Semi Bold only for the quote, citation should remain Regular. The line height should be 1,6. Alternatively, see Figma.

Currently Intended
Captura de ecrã 2023-09-20, às 12 04 18 Captura de ecrã 2023-09-20, às 12 06 32

This one seems to look the best default for the quote in a paragraph. If we want to just create a post that's a quote though, like the example below, is it possible to make the larger one default for such cases?

Captura de ecrã 2023-09-20, às 12 22 40
@richtabor
Copy link
Member

richtabor commented Sep 20, 2023

We can only have one default style. Currently it’s the bigger one, while “Plain” is the style with the border to the left. I think it’s fine to keep the default as it is today.

“Plain” comes from Gutenberg.

@beafialho
Copy link
Author

In your opinion, what should be the default?

@richtabor
Copy link
Member

I think the white one. The border one looks more "plain", which is the style name we have to use.

@beafialho
Copy link
Author

Ok, in any case, I suggest we improve the Plain one's appearance.

@beafialho beafialho changed the title Quote (Plain): Improve appearance, perhaps make default Sep 25, 2023
@MaggieCabrera MaggieCabrera added the [Status] Help Wanted Extra attention is needed label Sep 29, 2023
@luminuu
Copy link
Member

luminuu commented Oct 4, 2023

@beafialho Do you want to provide us some design that we can implement for the plain quote variant?

@beafialho
Copy link
Author

@luminuu it's in the screenshot above in the "Intended" column. Also here on Figma.

@MaggieCabrera
Copy link
Collaborator

I'm working on this and just the border requires an impressive amount of CSS to make it work on the three alignments plus RTL. We can do that, but it feels a little overkill to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] Help Wanted Extra attention is needed
4 participants