-
Notifications
You must be signed in to change notification settings - Fork 117
Style Variation: Sandstorm #420
Comments
We have a problem with the fonts in that if we have style variations that use the same font for heading and body they will show duplicated on the font families dropdown :( We decided to go around that by using Inter for the headings and the system font for the body on the sans-serif variations that you designed (discussed in #367 (comment)) |
Oh, that's weird... This variation uses Instrument Sans though. |
I know, but the result of having it apply to both body and headings will end up with two instances of Instrument sans, one for each of them |
So, we can't have a variation with just one font? Why is it a problem that it shows duplicated? |
just that it's confusing for the user, and also because we are enqueing the font twice, which is not great but also not terrible. @richtabor what do you think? |
Yea it’s a strange edge case we’re hitting. Perhaps we should open an issue to never duplicate fonts. I don’t expect it for 6.4, but would be good anyhow. Could we use inter for body font here as well? |
Let me rethink the variations. I'd love to use some different fonts. |
@beafialho that variation includes a lot of files for the fonts, do we need them all? we are only using 3 for Cardo on the main style. |
@beafialho If you want to reduce, we can just change heading font and not body. I've proposed it top-level here so we can use it in variations easily if wanted: #452. |
It may be best to lean on variable fonts only. |
No, we only need Instrument Sans and Jost here. Is it possible to use my file, just for the sake of the font sizes I set? |
What I meant is we are adding too many weights for the fonts |
Oh, variable works too if it's better due to size. Through the Create Block Plugin I just selected the fonts from the Google fonts dropdown, but I can send you the variable ones if you'd like. |
That helps, thank you. |
Here they are: |
sandstorm.json.zip
The text was updated successfully, but these errors were encountered: