Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Style Variation: Sandstorm #420

Closed
beafialho opened this issue Sep 19, 2023 · 16 comments · Fixed by #495
Closed

Style Variation: Sandstorm #420

beafialho opened this issue Sep 19, 2023 · 16 comments · Fixed by #495

Comments

@beafialho
Copy link

Captura de ecrã 2023-09-19, às 11 59 39 Captura de ecrã 2023-09-19, às 11 59 32

sandstorm.json.zip

@MaggieCabrera
Copy link
Collaborator

We have a problem with the fonts in that if we have style variations that use the same font for heading and body they will show duplicated on the font families dropdown :( We decided to go around that by using Inter for the headings and the system font for the body on the sans-serif variations that you designed (discussed in #367 (comment))

@beafialho
Copy link
Author

Oh, that's weird... This variation uses Instrument Sans though.

@MaggieCabrera
Copy link
Collaborator

Oh, that's weird... This variation uses Instrument Sans though.

I know, but the result of having it apply to both body and headings will end up with two instances of Instrument sans, one for each of them

@beafialho
Copy link
Author

So, we can't have a variation with just one font? Why is it a problem that it shows duplicated?

@MaggieCabrera
Copy link
Collaborator

So, we can't have a variation with just one font? Why is it a problem that it shows duplicated?

just that it's confusing for the user, and also because we are enqueing the font twice, which is not great but also not terrible. @richtabor what do you think?

@richtabor
Copy link
Member

richtabor commented Sep 20, 2023

Yea it’s a strange edge case we’re hitting. Perhaps we should open an issue to never duplicate fonts. I don’t expect it for 6.4, but would be good anyhow.

Could we use inter for body font here as well?

@beafialho
Copy link
Author

Let me rethink the variations. I'd love to use some different fonts.

@beafialho
Copy link
Author

Ok I think I found a nice solution for this one, using Instrument Sans for paragraphs and Jost for headings. Updated file here:

sandstorm-2.json.zip

Captura de ecrã 2023-09-20, às 14 51 57
@MaggieCabrera MaggieCabrera self-assigned this Sep 20, 2023
@MaggieCabrera
Copy link
Collaborator

@beafialho that variation includes a lot of files for the fonts, do we need them all? we are only using 3 for Cardo on the main style.

@richtabor
Copy link
Member

@beafialho If you want to reduce, we can just change heading font and not body. I've proposed it top-level here so we can use it in variations easily if wanted: #452.

@richtabor
Copy link
Member

that variation includes a lot of files for the fonts

It may be best to lean on variable fonts only.

@beafialho
Copy link
Author

@beafialho that variation includes a lot of files for the fonts, do we need them all?

No, we only need Instrument Sans and Jost here. Is it possible to use my file, just for the sake of the font sizes I set?

@MaggieCabrera
Copy link
Collaborator

What I meant is we are adding too many weights for the fonts

@beafialho
Copy link
Author

Oh, variable works too if it's better due to size. Through the Create Block Plugin I just selected the fonts from the Google fonts dropdown, but I can send you the variable ones if you'd like.

@MaggieCabrera
Copy link
Collaborator

That helps, thank you.

@beafialho
Copy link
Author

Here they are:

Instrument_Sans.zip
Jost.zip

@MaggieCabrera MaggieCabrera removed their assignment Sep 21, 2023
@luminuu luminuu mentioned this issue Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.