Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Review theme strings in different languages and normalize them in English #315

Closed
juanfra opened this issue Sep 11, 2023 · 3 comments
Closed

Comments

@juanfra
Copy link
Member

juanfra commented Sep 11, 2023

Description

We're implementing the patterns with localized texts in different languages (Italian is probably the most prominent). This will become a problem when we merge the theme into core, roll it out, and the translators don't understand how to translate the different strings, as some are in English and some are in Italian or other languages.

We should probably normalize the theme strings and have them in English.

@MaggieCabrera
Copy link
Collaborator

Yes. we've discussed this elsewhere but it's good that we have an issue to centralize the discussion. We've decided that the multi language text will only live int he demo site and that all the content of the theme will be in English. Some of the patterns have both English and non English versions in Figma, so let's use the English one where we can. Let's make a list of the patterns that need translating.

@beafialho we are going to need English text for the patterns that don't have it

@beafialho
Copy link

Sure, let me know which ones need the English translation

@richtabor
Copy link
Member

@beafialho here ya go:

CleanShot 2023-09-18 at 15 39 23 CleanShot 2023-09-18 at 15 38 35
@richtabor richtabor changed the title Review theme strings in different languages and normalize them in English. Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.