Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's make a way to run the theme-check via cli against arbitrary folders? #438

Open
georgestephanis opened this issue Dec 13, 2022 · 2 comments

Comments

@georgestephanis
Copy link

Previously: #2

Discussed in Slack here:

https://wordpress.slack.com/archives/C02RP4Y3K/p1670944400058739

It feels like being able to run the theme-check via wp-cli as something like

wp theme-check [slug]
wp theme-check /tmp/downloads/downloaded-theme/

to catch either installed themes and stuff in folders outside of WordPress itself -- as a way to run preflight checks, and potentially tie into deployments and github actions -- would be useful, so themes could be scanned not only from being installed, but arbitrary theme directories that aren't exposed to a functional installation.

@georgestephanis
Copy link
Author

georgestephanis commented Dec 13, 2022

As an ancillary thing, if it would be possible to also have documentation for how to set it up for GitHub actions, I suspect a number of themes that manage their code primarily on gh would be able to leverage it -- not necessarily on every commit, but as a pre-tagging-of-a-release check.

But that would be much more of a subsequent thing down the road.

@dd32
Copy link
Member

dd32 commented Apr 17, 2023

This would've made #448 much easier to test :)

If it helps anyone to implement this, the Theme Directory runs theme check via this code:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php?rev=12189&marks=1011-1041#L1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants