Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trademarks check fails should show as a warning #495

Closed
davidperezgar opened this issue Jul 6, 2024 · 1 comment · Fixed by #496
Closed

Trademarks check fails should show as a warning #495

davidperezgar opened this issue Jul 6, 2024 · 1 comment · Fixed by #496
Assignees
Labels
[Team] Plugin Review Issues owned by Plugin Review Team
Milestone

Comments

@davidperezgar
Copy link
Member

The plan for this plugin is to be in the submission form, and I cannot block uploads for example from WooCommerce. They actually upload plugins and if it marks the use of the trademark as error, will block the plugin upload.

If they get ERROR, it won't make a PASS, so we should change as a WARNING, and the plugin team can check manually the Plugin name.

@davidperezgar davidperezgar added the [Team] Plugin Review Issues owned by Plugin Review Team label Jul 6, 2024
@davidperezgar davidperezgar added this to the 1.1.0 milestone Jul 6, 2024
@davidperezgar davidperezgar self-assigned this Jul 6, 2024
@davidperezgar davidperezgar linked a pull request Jul 6, 2024 that will close this issue
@frantorres
Copy link
Contributor

Just to give context, today the submission form blocks submissions for certain-common slug beginnings (including some common trademarks).
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php#L613
In case some of this common trademarks wants to submit a plugin, they ask the plugin team for help to bypass that limitation.

@swissspidy swissspidy modified the milestones: 1.1.0, 1.0.2 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team
3 participants