Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer warning when running unit test #484

Closed
ernilambar opened this issue Jul 1, 2024 · 4 comments
Closed

Composer warning when running unit test #484

ernilambar opened this issue Jul 1, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@ernilambar
Copy link
Member

When I run test using command npm run test-php, following warning message appears after Starting 'composer install --no-dev' on the tests-cli container.

Composer could not detect the root package (wordpress/plugin-check) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version
@ernilambar ernilambar added the Infrastructure Issues for the overall plugin infrastructure label Jul 1, 2024
@swissspidy
Copy link
Member

Probably just a side effect of running Composer within wp-env? It doesn't happen when you run any Composer commands locally. In wp-env it might not have proper access to the .git folder or something, hence the warning. Also note that adding a version to composer.json is considered a bad practice, so I would not do that.

All in all, since this is just a warning occuring in wp-env, personally I would not bother looking into it.

@ernilambar
Copy link
Member Author

@swissspidy There is also another warning. Not sure whether it is Docker issue or wp-env issue.

WARN[0000] /Users/johndoe/.wp-env/27c26e959817828ceadc3831fb10f454/docker-compose.yml: `version` is obsolete 
@swissspidy
Copy link
Member

swissspidy commented Jul 1, 2024

That's simply wp-env that needs to be updated after docker-compose deprecated that field. That line needs to be removed: https://github.com/WordPress/gutenberg/blob/12518a05af35aa504f7c8b086cb6f255cf094f25/packages/env/lib/build-docker-compose-config.js#L178

@ernilambar ernilambar added wontfix This will not be worked on and removed Infrastructure Issues for the overall plugin infrastructure labels Jul 2, 2024
@ernilambar
Copy link
Member Author

Since both issues needs to be fixed upstream, I am closing this issue.

@ernilambar ernilambar closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
2 participants