Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk version not available on Subversion #432

Closed
ernilambar opened this issue Feb 20, 2024 · 7 comments
Closed

Trunk version not available on Subversion #432

ernilambar opened this issue Feb 20, 2024 · 7 comments

Comments

@ernilambar
Copy link
Member

Ref: https://translate.wordpress.org/projects/wp-plugins/plugin-check/

Why strings are not showing in Development? Any idea?

@swissspidy
Copy link
Member

Because the development version, i.e. trunk, currently only contains the readme and no code.

cc @bordoni

@bordoni
Copy link
Member

bordoni commented Feb 21, 2024

Ohh I see, good point. But the code under trunk would be the same as the Stable Tag:. I am not sure how we would benefit from having that.

I know there are other benefits from having trunk.

@ernilambar
Copy link
Member Author

I noticed this issue when translating. I use this plugin https://wordpress.org/plugins/force-update-translations/ But due to some issue, this plugin only downloads strings from Development.

@swissspidy
Copy link
Member

In theory you could actually put a beta or release candidate in trunk but I don't think we need that.

It's pretty normal for trunk + latest tag to be identical. It would also make it easier to use https://downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

Not using trunk is more confusing than useful.

@dd32
Copy link
Member

dd32 commented Mar 12, 2024

It's pretty normal for trunk + latest tag to be identical.

Yeah; Either have trunk+tag the same, or have trunk actually have the code from GitHub trunk sync'd daily/every push.

If the deploy workflow is used; it should set trunk contents to that of the stable release. I've just fixed the secrets/svn credentials for this repo.

It would also make it easier to use https://downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

for that, use https://downloads.wordpress.org/plugin/plugin-check.latest-stable.zip

@swissspidy
Copy link
Member

It's pretty normal for trunk + latest tag to be identical.

Yeah; Either have trunk+tag the same, or have trunk actually have the code from GitHub trunk sync'd daily/every push.

If the deploy workflow is used; it should set trunk contents to that of the stable release.

Correct. And we intended to use that workflow. But the initial 1.0.0 and 1.0.1 were pushed manually because the action timed out due to the many new files being added.

So right now the empty trunk folder prevents us from using this workflow.

So my tl;dr is: let's just fix this please to make our lives easier :)

I've just fixed the secrets/svn credentials for this repo.

Can you clarify this? The GitHub secrets in this repo should have been correct already (using the performanceteam user). What did you change these to now?

It would also make it easier to use downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

for that, use downloads.wordpress.org/plugin/plugin-check.latest-stable.zip

TIL! Thanks.

@swissspidy swissspidy changed the title Strings not showing in plugin translation Mar 26, 2024
@swissspidy
Copy link
Member

The code is now in trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants