Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Styles > Typography panel #63503

Open
1 of 5 tasks
richtabor opened this issue Jul 12, 2024 · 3 comments
Open
1 of 5 tasks

Improve Styles > Typography panel #63503

richtabor opened this issue Jul 12, 2024 · 3 comments
Labels
[Feature] Font Library Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Jul 12, 2024

Quite a few additions have been added to the Styles > Typography panel, but these changes were done in a piecemeal manner rather than following a cohesive plan.

Now that we have these pieces in place, let's explore how to clean up this panel and make it much more useful as a key component of styling a site's typography.

Tasks

Current

CleanShot 2024-07-12 at 16 47 16

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Font Library labels Jul 12, 2024
@richtabor
Copy link
Member Author

Also relevant (if the groupings are reverted): #63505

@richtabor
Copy link
Member Author

richtabor commented Jul 12, 2024

Remove "Manage fonts" button from Typography panel in favor of existing UX to open the Font Library (backtracking on #6212).

A potential path:

CleanShot 2024-07-12 at 17 23 12

  • "Add fonts" uses the same style as "Add background image" and related buttons.
  • The vertical ellipsis icon becomes a popover for additional affordances for intent.
@akasunil
Copy link
Member

#63125 would fix Use proper 40px height for all items within all ItemGroups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
2 participants