Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 6.6 RC 3: Block global styles in the site editor become stuck on the site frontend #63467

Closed
andrewserong opened this issue Jul 12, 2024 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release

Comments

@andrewserong
Copy link
Contributor

Description

Tracked in core in https://core.trac.wordpress.org/ticket/59595#comment:71 — note this is an issue in core, and not the Gutenberg repo. It's added here for visibility as it relates to behaviour with global styles in the site editor.

It looks like the caching strategy in WP 6.6 has resulted in a regression where the styles for blocks in global styles become stuck on the site frontend when a user goes to make updates to the styles for a block within global styles.

Step-by-step reproduction instructions

  1. Open the site editor on a WP 6.6 RC3 site running Twenty Twenty Four theme (without Gutenberg activated)
  2. Click the editor preview to go into edit mode
  3. Open the Global Styles sidebar panel on the right hand side
  4. Click Blocks
  5. Select the Button block
  6. Give the Button block a style, e.g. Background color set to a gradient
  7. Save the global styles
  8. Load the site frontend — notice that the styling on the Button is applied
  9. Go back to global styles and give the Button block another style, e.g. large font size
  10. Save the global styles
  11. Load the site frontend and notice that the Button block's styling has not changed — it'll be cached with the previous styles that were originally saved

Screenshots, screen recording, code snippet

2024-07-12.15.25.08.mp4

Environment info

  • WP 6.6 RC 3
  • Gutenberg is not active. This issue does not appear to occur in Gutenberg.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added [Type] Regression Related to a regression in the latest release Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jul 12, 2024
@andrewserong
Copy link
Contributor Author

andrewserong commented Jul 12, 2024

There is a potential draft fix open over in: WordPress/wordpress-develop#7017

@andrewserong
Copy link
Contributor Author

Closing this out now as the change that introduced the regression has been reverted in core. See: https://core.trac.wordpress.org/ticket/59595#comment:84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release
1 participant