Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboboxControl: Increase the size of the Reset button #63420

Open
afercia opened this issue Jul 11, 2024 · 0 comments
Open

ComboboxControl: Increase the size of the Reset button #63420

afercia opened this issue Jul 11, 2024 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 11, 2024

Description

A farily new design pattern in the editor places buttons in a way that they visually appear within a related input field. Examples of this pattern can be seen, for example, in the LinkControl and in the Post URL setting popover. Screenshot:

linkcontrol

post url popover

As an accessibility specialist, I'm not sure I'd support this pattern because the visual appearance of a button inside an input field is somehow unexpected and disorienting.

Regardless, this pattern should at least be consistent.

Turns out the ComboboxControl does have an optional Reset button. Its size is way smaller and it's pretty inconsistent.

Also, a control target size should be as large as possible. This one is too small. Screenshot:

reset

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Components /packages/components labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
1 participant