Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Improve 'No fonts installed' state when fonts are installed but not activated #63418

Closed
Tracked by #60528
afercia opened this issue Jul 11, 2024 · 0 comments · Fixed by #63533
Closed
Tracked by #60528
Assignees
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 11, 2024

Description

Splitting this out from #63211 (comment)

Cc @matiasbenedetto

WHen there are fonts installed but none of them is activated, the UI still refers to a 'no fonts installed' verbiaage:

  • Th Styles panel shows a 'No fonts installed.` text,
  • The button that opens the modal dialog text is 'Add fonts'.
  • The button to open the modal dialog brings users to the 'Upload' tab. It would be best to bring users to the 'Library' tab.

This UI could be improved to clarify there are fonts installed, they're just not active

Screenshot 2024-07-11 at 12 00 35

Step-by-step reproduction instructions

  • Go to the Site editor > Styles > Typography
  • Make sur eto have some fonts installed.
  • Deactivate all fonts.
  • Close the fonts modal dialog
  • Observe the 'No fonts installed.' text in the Styles panel
  • Observe the 'Add fonts' button text

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Feature] Font Library labels Jul 11, 2024
@creativecoder creativecoder changed the title Font Library: Improve 'No fonts installed' state when fonts are installed but not acitvated Jul 12, 2024
@akasunil akasunil self-assigned this Jul 14, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants