Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: white space at the very bottom of the results #63384

Closed
annezazu opened this issue Jul 10, 2024 · 4 comments · Fixed by #63397
Closed

Inserter: white space at the very bottom of the results #63384

annezazu opened this issue Jul 10, 2024 · 4 comments · Fixed by #63397
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Using 6.6 RC 3 on an InstaWP site, I noticed that if I searched for a block then scrolled down the inserter to see the block directory offerings, I could keep scrolling and end up in an endless white space:

inserter.mov

Curious if others can replicate:

  1. Add a new post
  2. Open the inserter
  3. Search for something like "blog"
  4. Notice that there's a bunch of white space as you scroll down to the bottom of the inserter
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Jul 10, 2024
@annezazu annezazu changed the title Inserter: Jul 10, 2024
@talldan
Copy link
Contributor

talldan commented Jul 11, 2024

Curious if others can replicate:

Yep, I can. There were quite a lot of scroll related bugs in 6.6, seems like this is yet another.

@talldan
Copy link
Contributor

talldan commented Jul 11, 2024

I had massive deja vu with this one, and it seems like it was also a bug in 6.5, but was apparently fixed:
Users can scroll off the bottom of the block editor into a forbidden void when searching in the inserter

Looks like there were two fixes:

Maybe those fixes were somehow undone.

@talldan
Copy link
Contributor

talldan commented Jul 11, 2024

As mentioned by @jeryj, it's the block directory results that cause the issue - #57127 (comment).

Specifically there's some visually hidden text in the the blocks in the block directory results that's set to position: absolute. You can get these weird scroll issues when there's an element set to position: absolute; if the element is positioned relative to something outside of the scroll container, so that's why setting position: relative on a parent fixes it.

This was really causing massive deja vu again. Seems like I also fixed another similar issue in that past - #44853. 😄

@ellatrix
Copy link
Member

@talldan Any reason this is moved out of Done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
3 participants