Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-entity save: reverse order of save and cancel buttons when saving in the frame #63372

Open
annezazu opened this issue Jul 10, 2024 · 6 comments
Labels
[Feature] Saving Related to saving functionality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

When saving changes in the frame rather than in the canvas, the order of the buttons should be reversed to make it more obvious to click the primary call to action ("save"). Generally, the primary action for items is often found on the right side.

Current:

Screenshot 2024-07-10 at 10 30 04 AM

Proposed

Screenshot 2024-07-10 at 10 35 47 AM

Of note, currently when saving in the canvas/editor, we show a similar order to the current and I wonder if we should also update there:

Screenshot 2024-07-10 at 10 36 55 AM

cc @WordPress/gutenberg-design for more context and thoughts.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Saving Related to saving functionality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 10, 2024
@jasmussen
Copy link
Contributor

I would think both of these interfaces could use substantial design refreshes. But that shouldn't block this.

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jul 11, 2024
@jameskoster
Copy link
Contributor

I wonder if we should also update there

That will probably be necessary to avoid falling foul of a11y requirements (visual order should match DOM order).

@richtabor
Copy link
Member

One note: if the save and cancel buttons are inverted in the second publish sidebar, when you press Save and the sidebar opens up, you'll press the cancel button almost immediately.

@jasmussen
Copy link
Contributor

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

Option

Figma.

@richtabor
Copy link
Member

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

If we do, should the Inspector icon always be first next to it? So that it's consistently in the same place?

@jasmussen
Copy link
Contributor

Yes, like so, good catch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
4 participants