Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: editing aspect ratio isn't respected when selecting square option #63319

Closed
annezazu opened this issue Jul 9, 2024 · 8 comments
Closed
Labels
[Block] Image Affects the Image Block [Block] Site Logo Affects the Site Logo Block REST API Interaction Related to REST API [Type] Regression Related to a regression in the latest release

Comments

@annezazu
Copy link
Contributor

annezazu commented Jul 9, 2024

When testing 6.6 RC2, after adding an image to the site logo block, I tried cropping the image and setting aspect ratio to square. After selecting apply, the setting doesn't stick and the site logo isn't 1:1:

crop.site.logo.mov

In 6.5.5, this works as expected and the aspect ratio is changed to 1:1.

Opening this to be safe with the final RC out today but will test with RC3 later today!

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Site Logo Affects the Site Logo Block labels Jul 9, 2024
@ellatrix
Copy link
Member

ellatrix commented Jul 9, 2024

Looks like this is broken for image too (so generally). The edit request looks fine, it looks like something is going wrong server side.

@ellatrix ellatrix added [Block] Image Affects the Image Block REST API Interaction Related to REST API labels Jul 9, 2024
@ellatrix
Copy link
Member

ellatrix commented Jul 9, 2024

I checked out the wp/6.5 branch for Gutenberg, and it's still broken. Yet it works for WP 6.5. That tells me the problem is somewhere on the REST API side in core. Maybe we should create an issue there too?

@ellatrix ellatrix added [Type] Regression Related to a regression in the latest release and removed [Type] Bug An existing feature does not function as intended labels Jul 9, 2024
@ellatrix
Copy link
Member

ellatrix commented Jul 9, 2024

I filed this Trac issue for visibility: https://core.trac.wordpress.org/ticket/61612.
Also marked it high priority/major severity, since I think it's a pretty bad bug.

@annezazu
Copy link
Contributor Author

annezazu commented Jul 9, 2024

Thank you so much, Ella!

@Mamaduka
Copy link
Member

Mamaduka commented Jul 9, 2024

Looks similar to #62855.

@ellatrix
Copy link
Member

ellatrix commented Jul 9, 2024

Yes, this has actually just been fixed a few hours ago in core in https://core.trac.wordpress.org/ticket/61514, so it's in RC 3!

@ellatrix ellatrix closed this as completed Jul 9, 2024
@annezazu
Copy link
Contributor Author

annezazu commented Jul 9, 2024

WHEW! Awesome. I didn't catch that when looking for site logo specific issues (rather than image) so thank you for connecting things.

@andrewserong
Copy link
Contributor

+1 thank you for connecting these, and great to hear that the fix landed in time for RC 3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Site Logo Affects the Site Logo Block REST API Interaction Related to REST API [Type] Regression Related to a regression in the latest release
4 participants