Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLPopover: improve vertical alignment of the Apply and Link settings buttons #63294

Closed
afercia opened this issue Jul 9, 2024 · 0 comments · Fixed by #63316
Closed

URLPopover: improve vertical alignment of the Apply and Link settings buttons #63294

afercia opened this issue Jul 9, 2024 · 0 comments · Fixed by #63316
Assignees
@amitraj2203
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 9, 2024

Description

In the URLPopover, the 'Apply' and 'Link settings' buttons aren't vertically aligned with the input field. Screenshot with the input and buttons focused to better to illustrate:

Screenshot 2024-07-09 at 13 56 02

Addind align-items: center; to both .block-editor-url-popover__row and .block-editor-format-toolbar__link-container-content should fix it.

Step-by-step reproduction instructions

  • Add an Image block.
  • Select the block and click the 'Link' button in the block toolbar.
  • Observe the URL input and the buttons aren't vertically aligned.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor labels Jul 9, 2024
@amitraj2203 amitraj2203 mentioned this issue Jul 9, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants
@afercia @amitraj2203